[
https://issues.apache.org/jira/browse/CXF-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620886#action_12620886
]
Andreas Benneke commented on CXF-1737:
--------------------------------------
Simon, thanks for looking into it. I've just attached a test case to reproduce
the exception.
According to my tests, the following assertions are all valid:
assertTrue(Void.TYPE.equals(void.class));
assertFalse(Void.class.equals(void.class));
assertFalse(Void.class.equals(Void.TYPE));
Therefore, as far as I see the change you propose would not change anything.
One could however be on the very save side by doing somthing like this:
@Override
public Boolean hasOutMessage(Method m) {
Class rt = m.getReturnType().getClass();
if ((rt.equals(Void.TYPE) || rt.equals(Void.class)) &&
m.getExceptionTypes().length == 0) {
return false;
}
return true;
}
> NPE in ClientProxyFactoryBean on void methods
> ----------------------------------------------
>
> Key: CXF-1737
> URL: https://issues.apache.org/jira/browse/CXF-1737
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.1
> Reporter: Andreas Benneke
> Attachments: void.zip
>
>
> If you try to access a service containing a method returning nothing (void),
> the ClientProxyFactoryBean fails with a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.cxf.service.factory.ReflectionServiceFactoryBean.initializeParameter(ReflectionServiceFactoryBean.java:643)
> at
> org.apache.cxf.service.factory.ReflectionServiceFactoryBean.initializeClassInfo(ReflectionServiceFactoryBean.java:609)
> at
> org.apache.cxf.service.factory.ReflectionServiceFactoryBean.initializeWSDLOperation(ReflectionServiceFactoryBean.java:540)
> at
> org.apache.cxf.service.factory.ReflectionServiceFactoryBean.initializeWSDLOperations(ReflectionServiceFactoryBean.java:510)
> at
> org.apache.cxf.service.factory.ReflectionServiceFactoryBean.buildServiceFromWSDL(ReflectionServiceFactoryBean.java:305)
> at
> org.apache.cxf.service.factory.ReflectionServiceFactoryBean.initializeServiceModel(ReflectionServiceFactoryBean.java:394)
> at
> org.apache.cxf.service.factory.ReflectionServiceFactoryBean.create(ReflectionServiceFactoryBean.java:181)
> at
> org.apache.cxf.frontend.AbstractWSDLBasedEndpointFactory.createEndpoint(AbstractWSDLBasedEndpointFactory.java:79)
> at
> org.apache.cxf.frontend.ClientFactoryBean.create(ClientFactoryBean.java:51)
> at
> org.apache.cxf.frontend.ClientProxyFactoryBean.create(ClientProxyFactoryBean.java:97)
> If you change the method returning something or eliminate the method
> altogether, everything works fine...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
