[
https://issues.apache.org/jira/browse/CXF-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Masters updated CXF-1859:
---------------------------------
Attachment: MessageUtils.patch
I changed the fix to use equalsIgnoreCase() because the suggested
implementation would allow "yes". I wasn't sure if this was acceptable. I ran
all the tests and they passed. I was going to write a unit test for this, but
there wasn't a MessageUtilsTest.java file. What is the testing policy? I was
going to create the test class, but I wanted to ask before doing so.
I've never submitted a patch before, so any input would be awesome.
cheers,
Mike
> mtom-enabled property case sensitive
> ------------------------------------
>
> Key: CXF-1859
> URL: https://issues.apache.org/jira/browse/CXF-1859
> Project: CXF
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.0.8
> Environment: jdk1.5
> Reporter: Adrian Corcoran
> Priority: Minor
> Attachments: MessageUtils.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Setting of jax-ws endpoint property mtom-enabled is case sensitive - setting
> value to 'TRUE' rather than 'true' will not enable mtom.
> The root of this problem is in MessageUtils.
> public static boolean isTrue(Object value) {
> if (Boolean.TRUE.equals(value) || "true".equals(value)) {
> return true;
> }
>
> return false;
> }
> This should obviously be
> public static boolean isTrue(Object value) {
> return Boolean.valueOf(value.toString());
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
