[ 
https://issues.apache.org/jira/browse/CXF-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648368#action_12648368
 ] 

Daniel Kulp commented on CXF-1917:
----------------------------------


Ummm... no it cannot be moved into AttachmentInInterceptor.    The interceptors 
are re-entrant.  Thus, there could be multiple threads currently in the 
AttachmentInInterceptor, all with their own message and thus, there would be 
all kinds of issues if they all called ad.setMessage(...) at the same time.

I also don't know what the problem is.   The Patter is a static.   Thus, it's 
compiled once and only once.   They aren't compiled for every message.



> Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during 
> invocation
> -------------------------------------------------------------------------------------
>
>                 Key: CXF-1917
>                 URL: https://issues.apache.org/jira/browse/CXF-1917
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.7
>         Environment: Windows XP, Java SE 1.6
>            Reporter: Mayank Mishra
>            Priority: Minor
>         Attachments: AttachmentDeserializer.patch, 
> AttachmentInInterceptor.patch
>
>
> AttachmentDeserializer contains static java.util.regex.Patterns which 
> compiled for particular String expressions, which takes substantial time in 
> milliseconds (around 50-100 ms). 
> AttachmentDeserializer instance is created in AttachmentInInterceptor during 
> handleMessage() call. This can be moved to AttachmentInInterceptor 
> constructor, and provided a setMessage(Message message) method in 
> AttachmentDerserializer, we can set message during handleMessage() call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to