[SoapBindingFactory] Verify QName properties before calling constructor
-----------------------------------------------------------------------

                 Key: CXF-2327
                 URL: https://issues.apache.org/jira/browse/CXF-2327
             Project: CXF
          Issue Type: Improvement
          Components: Soap Binding
    Affects Versions: 2.1.2
            Reporter: Kenny MacLeod
            Priority: Minor


The QName constructor verifies that the localPart property is not null. 
However, when this exception is thrown during a WSDL2Java invocation, all you 
get is a pretty useless "local part cannot be "null" when creating a QName" 
message. 

It would be good if CXF were to check these values before constructing a QName, 
and if the localPart is null then throw a more meaningful exception, indicating 
where in the WSDL it is occurring.

A concrete example is the SoapBindingFactory.initializeMessage method.  If 
QName's constructor throws an exception anywhere in here, it's very hard to 
figure out which part of the WSDL was bad, since there are so many nested 
structures. If this method were to proactively check that localPart was null 
before constructing QName, it could throw an excepyion indicating which part of 
the WSDL was at fault, making diagnosis a lot easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to