[ 
https://issues.apache.org/jira/browse/CXF-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kulp reopened CXF-2931:
------------------------------



I'm reopening this as I have two issues with the code that was committed:

1) Please do not create a transformer or parser or anything directly.  Make 
sure you go through XMLUtils or StaxUtils to do so.   I learned from the 
security issue that having all of that in one place makes changing things if 
needed MUCH MUCH easier. 

2) If this is configured on a Bus level (common for logging) but a non XML 
request goes through, what happens?    For example, a JAXRS JSON thing or 
similar?   I think this needs to check the content type or something to make 
sure it really is XML before doing an XML transform on it.



> Add configurable pretty printing to the CXF logging in/out interceptors
> -----------------------------------------------------------------------
>
>                 Key: CXF-2931
>                 URL: https://issues.apache.org/jira/browse/CXF-2931
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3, 2.2.10
>
>
> Currently the logging in/out interceptors only print the raw message without 
> any additional formatting, in many cases making it difficult to read 
> requests/replies in the logging. We should have ability in these interceptors 
> to turn on a flag and have messages logged with proper indentation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to