[
https://issues.apache.org/jira/browse/CXF-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933927#action_12933927
]
Daniel Kulp commented on CXF-3137:
----------------------------------
Patch looks good. It definitely simplifies things quite a bit. All the work
you are doing should make it easier to get my AsyncClient version working a
little easier as well as things are cleaned up and put into smaller work units
and such.
At one point, I think there was an intention to have the ConnectionInfo object
added to the message to allow other things besides the Trust things to use it,
but looking at the code, that never happened. Thus, I'm definitely OK with
what's in the patch.
> Simplify http connection factory in http transport (please review)
> -------------------------------------------------------------------
>
> Key: CXF-3137
> URL: https://issues.apache.org/jira/browse/CXF-3137
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.3.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.3.1
>
> Attachments: cxf-rt-transports-http-3137.patch
>
>
> Currently the http transport uses a quite complicated way to create http url
> connections. There are two factories (for http and https). One is selected
> and cached. Then when you change the config of the transport it is eventually
> replaced.
> I propose to make this much simpler by having only a https url connection
> factory that also handles the http case. The new code has one little drawback
> it also eliminates the ConnectionInfo classes partly. I think that is not a
> big issue as I think this classes are only used for https trust decisions. It
> would be great though if someone could review the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
