Refactor toSQL method as visitor pattern
----------------------------------------

                 Key: CXF-3145
                 URL: https://issues.apache.org/jira/browse/CXF-3145
             Project: CXF
          Issue Type: Improvement
          Components: JAX-RS
    Affects Versions: 2.3.0
            Reporter: Brian Topping
            Priority: Minor


In doing some work with the FIQL parser, I needed to generate a different 
output than SQL.  By using a visitor pattern for rendering the SQL, any visitor 
can be applied to the SearchCondition object graph.

The attached patch provides that refactoring. 

As a part of that, SearchCondition.toSql() is deprecated, but I maintained the 
interface for maximum compatibility.  

There was also a change to SearchCondition.getSearchConditions().  There were 
no callers to that code except test code, and it was set up to return null if 
there was only one condition.  That wasn't clear to me, hopefully that change 
is not unreasonable.

This may not be formatted properly, please adjust to suit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to