[jira] [Commented] (CXF-3821) FormEncodingProvider does not check for null incoming object

[Mark Mc Kenna (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CXF-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112491#comment-13112491
 ] 

Mark Mc Kenna commented on CXF-3821:
------------------------------------

In the below function clazz can be null and when clazz.newInstance() is called 
NPE is thrown

    protected MultivaluedMap<String, String> createMap(Class<?> clazz) throws 
Exception {
        if (clazz == MultivaluedMap.class || clazz == Form.class) {
            return new MetadataMap<String, String>();
        }else if (clazz != null){
        return (MultivaluedMap<String, String>)clazz.newInstance();
        }
    }

I have overwritten createMap to ..........

         @Override
            protected javax.ws.rs.core.MultivaluedMap<String, String> 
createMap(final java.lang.Class<?> clazz)
                    throws InstantiationException, IllegalAccessException {
                if (clazz == MultivaluedMap.class || clazz == Form.class) {
                    return new MetadataMap<String, String>();
                } else if (clazz != null) {
                    return (MultivaluedMap<String, String>) clazz.newInstance();
                }
                return null;
            };

> FormEncodingProvider does not check for null incoming object
> ------------------------------------------------------------
>
>                 Key: CXF-3821
>                 URL: https://issues.apache.org/jira/browse/CXF-3821
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.4.2
>            Reporter: Mark Mc Kenna
>            Priority: Minor
>
> FormEncodingProvider does not check for null incoming object. A NPE is then 
> thrown at line FormEncodingProvider Line 133

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira