[
https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Shakirin updated CXF-4248:
---------------------------------
Description:
Hi,
Test case: Web service provides oneWay operation (SoapUI mock), but sends
non-empty SOAP response back
Expected: response will be ignored
Actual: DocLiteralInInterceptor throws NPE
Caused by: java.lang.NullPointerException
at
org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
at
org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
at
org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
at
org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
at
org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
at
org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
at
org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
at
org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
rInterceptor.java:62)
Fix proposal: I have discovered that there are some cases when oneWay response
can be proceeded. Regarding Basic Profile 1.1:
R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
One-way operations typically do not produce SOAP responses. However, some
INSTANCEs may choose to communicate infrastructure-related faults (e.g.
MustUnderstand, VersionMismatch) in the HTTP Response message.
In addition to this, the use of some protocol extensions (e.g.
WS-ReliableMessaging) may create the possibility for non-empty responses to
one-way messages. For these reasons the Basic Profile 1.1 requirement that the
HTTP Response message not contain a SOAP envelope has been relaxed.
I would propose to process successful oneWay responses only in following cases:
A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND,
RMMessageConstants.RM_PROPERTIES_INBOUND)
B) if user activate it with org.apache.cxf.transport.processOneWayResponse
property on client.
In other case oneWay response will be ignored by client.
Patch is attached.
Regards,
Andrei.
was:
Hi,
Test case: Web service provides oneWay operation (SoapUI mock), but sends
non-empty SOAP response back
Expected: response will be ignored
Actual: DocLiteralInInterceptor throws NPE
Caused by: java.lang.NullPointerException
at
org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
at
org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
at
org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
at
org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
at
org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
at
org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
at
org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
at
org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
rInterceptor.java:62)
Fix proposal: I have discovered that there are some cases when oneWay response
can be proceeded. Regarding Basic Profile 1.1:
R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
One-way operations typically do not produce SOAP responses. However, some
INSTANCEs may choose to communicate infrastructure-related faults (e.g.
MustUnderstand, VersionMismatch) in the HTTP Response message.
In addition to this, the use of some protocol extensions (e.g.
WS-ReliableMessaging) may create the possibility for non-empty responses to
one-way messages. For these reasons the Basic Profile 1.1 requirement that the
HTTP Response message not contain a SOAP envelope has been relaxed.
I would propose to process successful oneWay responses only in following cases:
A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND,
RMMessageConstants.RM_PROPERTIES_INBOUND)
B) if user activate it with org.apache.cxf.transport.processOneWayResponse
property on consumer
In other case oneWay response will be ignored by client.
Patch is attached.
Regards,
Andrei.
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty
> response
> -------------------------------------------------------------------------------
>
> Key: CXF-4248
> URL: https://issues.apache.org/jira/browse/CXF-4248
> Project: CXF
> Issue Type: Improvement
> Reporter: Andrei Shakirin
> Priority: Minor
> Attachments: HTTPConduit.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends
> non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
> at
> org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
> at
> org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
> at
> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
> at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
> at
> org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
> at
> org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
> at
> org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
> at
> org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
> at
> org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
> at
> org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered that there are some cases when oneWay
> response can be proceeded. Regarding Basic Profile 1.1:
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an
> envelope.
> One-way operations typically do not produce SOAP responses. However, some
> INSTANCEs may choose to communicate infrastructure-related faults (e.g.
> MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to
> one-way messages. For these reasons the Basic Profile 1.1 requirement that
> the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following
> cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND,
> RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse
> property on client.
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
