[ 
https://issues.apache.org/jira/browse/CXF-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264870#comment-13264870
 ] 

Aster Anto commented on CXF-4273:
---------------------------------

Well, site seems to be okay now. I couldn't find any delegation in 
"WebClient.fromClient(Client)" method as you mentioned. Yes, it is been taken 
to the next method -"WebClient fromClient(Client client, boolean 
inheritHeaders)" but then again a new "WebClient" is being created there based 
on the existing client. 

To make proxy to WebClient conversion simpler, May be we can try

{noformat}WebClient webClient =  WebClient.fromClient((Client) 
proxy);{noformat}  

The only advantage "WebClient.client(proxy)" method provides is the instanceof 
expression, other than that, "WebClient.client(proxy)" method is just doing the 
casting.
Still I feel, its better to keep it the way it is now. Simple and less 
confusion for an average reader.
                
> WebClient.create(proxy) - does not exist
> ----------------------------------------
>
>                 Key: CXF-4273
>                 URL: https://issues.apache.org/jira/browse/CXF-4273
>             Project: CXF
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 2.6
>            Reporter: Aster Anto
>            Assignee: Sergey Beryozkin
>            Priority: Minor
>              Labels: documentation
>
> Referring to http://cxf.apache.org/docs/jax-rs-client-api.html
> Method matching the following does not exist.
> {noformat}WebClient client = WebClient.create(proxy);{noformat}
> However, I got a WebClient from proxy by,
> {noformat}BookStore proxy = JAXRSClientFactory.create("http://books";, 
> BookStore.class);
> Client client = WebClient.client(proxy);
> WebClient webClient = WebClient.fromClient(client);{noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to