[ 
https://issues.apache.org/jira/browse/CXF-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540538#comment-13540538
 ] 

Andrei Shakirin edited comment on CXF-4289 at 12/28/12 5:50 PM:
----------------------------------------------------------------

Headers aren't copied from inbound message as was described in issue, however 
AbstractJAXWSMethodInvoker.updateHeader() copies all headers already set into 
outbound context (except security ones) to Fault (method checks header 
directions and copies only INOUT and OUT).
It makes sense to disable this behavior through property, because in some cases 
headers prepared for normal response should not be sent if fault occurs.

Cheers,
Andrei.
                
      was (Author: ashakirin):
    Headers aren't copied from request as was described in issue, however 
AbstractJAXWSMethodInvoker.updateHeader() copies all headers already set into 
response (except security ones) to Fault (method checks header directions and 
copies only INOUT and OUT).
It makes sense to disable this behavior through property, because in some cases 
headers prepared for normal response should not be sent if fault occurs.

Cheers,
Andrei.
                  
> Coping Request SOAP Headers to Fault response
> ---------------------------------------------
>
>                 Key: CXF-4289
>                 URL: https://issues.apache.org/jira/browse/CXF-4289
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Assignee: Ulhas Bhole
>            Priority: Minor
>         Attachments: JAXWSMethodInvoker.patch
>
>
> Hi,
> Actually JAXWSMethodInvoker and AbstractJAXWSMethodInvoker contain code to 
> copy request soap headers (except security one) to SOAP Fault: 
> AbstractJAXWSMethodInvoker.updateHeader().
> I see some use cases when it is not really desired:
> 1) Request SOAP headers contains some labelling information about request 
> elements and they make sense only with request
> 2) Request SOAP headers extending request elements with meta-information
> If request headers are copied into fault response, they can be invalid in 
> response context and cause undesired effects:
> a) it makes response processing on the client side more difficult, especially 
> if processing interceptor is called before incoming fault message is 
> recognized and placed into exchange.getInFaultMessage()
> b) response fault message has larger size
> Proposal is to define context property that give user the possibility to 
> switch-off coping request headers into fault response.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to