[ 
https://issues.apache.org/jira/browse/CXF-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768206#comment-13768206
 ] 

Jason Pell edited comment on CXF-5273 at 9/16/13 10:10 AM:
-----------------------------------------------------------

As the author of CXF-5151 I am interested to understand why using the 
interceptor names causes problems.  Since I exclude all but the 3 interceptors, 
there is no chance of including anything but those 3.

I suppose if customers replaced MessageSenderInterceptor or StaxOutInterceptor 
then that could be an issue.

For my own understanding and to avoid this kind of thing in future, would be 
great if you can comment in this issue about exactly what situations were 
problematic.

Since the original WSDL Get Interceptor bypassed the the outgoing chain almost 
completely (by accessing the back channel conduit) I am interested to know how 
this change will impact users.


                
      was (Author: jpell):
    As the author of CXF-5151 I am interested to understand why using the 
interceptor names causes problems.  Since I exclude all but the 3 interceptors, 
there is no chance of including anything but those 3.

I suppose if customers replaced MessageSenderInterceptor or StaxOutInterceptor 
then that could be an issue.

For my own understanding and to avoid this kind of thing in future, would be 
great if you can comment in this issue about exactly what situations were 
problematic.

Since the original WSDL Get Interceptor did not bypassed the the outgoing chain 
almost completely I am interested to know how this change will impact users.


                  
> Filter the interceptor according to Phase instead of class name in 
> WSDLGetInterceptor
> -------------------------------------------------------------------------------------
>
>                 Key: CXF-5273
>                 URL: https://issues.apache.org/jira/browse/CXF-5273
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>
> Current WSDLGetInterceptor build up the out message interceptor chain like 
> this
> {code}
> Iterator<Interceptor<? extends Message>> iterator = 
> mout.getInterceptorChain().iterator();
>             while (iterator.hasNext()) {
>                 Interceptor<? extends Message> inInterceptor = 
> iterator.next();
>                 if (!inInterceptor.getClass().equals(StaxOutInterceptor.class)
>                     && 
> !inInterceptor.getClass().equals(GZIPOutInterceptor.class)
>                     && 
> !inInterceptor.getClass().equals(MessageSenderInterceptor.class)) {
>                     mout.getInterceptorChain().remove(inInterceptor);
>                 }
>             }
> {code}
> It causes some troubles when users use some customer interceptors.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to