[ 
https://issues.apache.org/jira/browse/CXF-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844024#comment-13844024
 ] 

Christian Schneider edited comment on CXF-5439 at 12/10/13 8:46 AM:
--------------------------------------------------------------------

I think we have two kinds of configurations to make.
On one side we might want to mark interceptors and features for automatic 
inclusion into all endpoints.
For this part I think the service loader concept should be good enough already. 
It allows to at least add features for automatic inclusion. Does it also 
already allow to mark interceptors?

On the other side we want to mark endpoints with interceptors and features to 
add.
There we already have annotations.

I also would like to pick up on the argument that creating features for single 
interceptors seems to be overkill.
It is more complicated on the side of the creator of a feature that is true. 
Still I think we should consider to limit configuration on the endpoint and 
proxy side to only features. It would make our configurations and annotations 
much simpler. I also would like to discuss identifying features by a symbolic 
name instead of by class name. The advantage is that it decouples endpoints 
from feature / interceptor implementations. We have good experiences with this 
approach in DOSGi (intentions) and it should also work for general usage.

I plan to create a wiki page to collect ideas how to ideally define and inject 
things like endpoint and features for various frameworks. I think the way we 
currently add more and more proprietary config styles leads to quite a lot of 
complexity, fragility and instability in the long term. Of course the earliest 
point to change this would probably be cxf 4.

[~sergey_beryozkin] I do not intend to veto your idea or something. If you 
think it is necessary go ahead. IN the long term though I think we have to make 
cxf simpler in a quite radical way.


was (Author: [email protected]):
I think we have two kinds of configurations to make.
On one side we might want to mark interceptors and features for automatic 
inclusion into all endpoints.
For this part I think the service loader concept should be good enough already. 
It allows to at least add features for automatic inclusion. Does it also 
already allow to mark interceptors?

On the other side we want to mark endpoints with interceptors and features to 
add.
There we already have annotations.

I also would like to pick up on the argument that creating features for single 
interceptors seems to be overkill.
It is more complicated on the side of the creator of a feature that is true. 
Still I think we should consider to limit configuration on the endpoint and 
proxy side to only features. It would make our configurations and annotations 
much simpler. I also would like to discuss identifying features by a symbolic 
name instead of by class name. The advantage is that it decouples endpoints 
from feature / interceptor implementations. We have good experiences with this 
approach in DOSGi (intentions) and it should also work for general usage.


> Introduce annotations for marking CXF interceptors and features to enable the 
> auto-discovery
> --------------------------------------------------------------------------------------------
>
>                 Key: CXF-5439
>                 URL: https://issues.apache.org/jira/browse/CXF-5439
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sergey Beryozkin
>            Priority: Minor
>             Fix For: 3.0.0-milestone2
>
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to