[ 
https://issues.apache.org/jira/browse/CXF-5509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bright Zheng updated CXF-5509:
------------------------------

    Attachment: learning-spring_cxf.zip

I attached a full sample project for your review purpose.

The major point could be demonstrated as below:
{code:java}
public class People<T extends Person> {
    
    public People(){}

        //It doesn't work in Apache CXF if using T[]
    /**
     * Nested in org.springframework.beans.factory.BeanCreationException: 
     * ...
     * Error creating bean with name 'personService': Invocation of init method 
failed; 
     * nested exception is javax.xml.ws.WebServiceException: 
java.lang.NullPointerException:
     * java.lang.NullPointerException
     *  at java.lang.reflect.Array.newArray(Native Method)
     *  at java.lang.reflect.Array.newInstance(Array.java:52)
     *  at 
org.apache.cxf.aegis.type.TypeUtil.getTypeRelatedClass(TypeUtil.java:259)
     * ...
     */
    private T[] persons;
    
    public T[] getPersons() {
                return persons;
        }

        public void setPersons(T[] persons) {
                this.persons = persons;
        }

        @SuppressWarnings("unchecked")
        public void addPerson(T person) {
                List<T> _persons = new ArrayList<T>();
                
                if(this.persons==null){                 
                        this.persons = 
(T[])Array.newInstance(person.getClass(), 1);
                }else{
                        for(T _person: this.persons){
                                _persons.add(_person);
                        }
                        this.persons = 
(T[])Array.newInstance(person.getClass(), this.persons.length + 1);
                }
                _persons.add(person);
                _persons.toArray(this.persons);
        }
    
    

        //It works well if using List<T> like below
    /*
    private List<T> persons = new ArrayList<T>();

        public List<T> getPersons() {
                return persons;
        }

        public void setPersons(List<T> persons) {
                this.persons = persons;
        }
        
        public void addPerson(T person){
                persons.add(person);
        }*/
    
}
{code}

> NullPointerException if class with generic-array parameters is set to 
> rootClassNames
> ------------------------------------------------------------------------------------
>
>                 Key: CXF-5509
>                 URL: https://issues.apache.org/jira/browse/CXF-5509
>             Project: CXF
>          Issue Type: Bug
>          Components: Aegis Databinding
>    Affects Versions: 2.7.8
>         Environment: RHEL6.3 (64b), JDK1.6, Spring 3.0.6, CXF 2.7.8
>            Reporter: Bright Zheng
>              Labels: NPE, aegis, binding, cxf, generic
>         Attachments: learning-spring_cxf.zip
>
>
> I want to expose a set of classes by setting the aegisContext:
> {code:xml}
> <bean id="aegisContext" class="org.apache.cxf.aegis.AegisContext" 
> scope="prototype">
>         <property name="writeXsiTypes" value="true"/>
>         <property name="rootClassNames">
>             <ref bean="bindingList"/>
>         </property>
> </bean>
> {code}
> One of the class in the list is as a response pojo which has generic-array 
> field like:
> {code:java}
> public class Subject<T extends Score>{
> ...
>       private T[] score;
>         //and getter/setter also
> ...
> {code}
> During the deployment phase, while debugging with the CXF code, I found that 
> below codes in TypeUtil.java under cxf-rt-databinding-aegis-2.7.8.jar will 
> case issue:
> {code:java}
> public static Class<?> getTypeRelatedClass(Type type) {
>         Class<?> directClass = getTypeClass(type, false);
>         if (directClass != null) {
>             return directClass;
>         }
>         
>         if (type instanceof ParameterizedType) {
>             ParameterizedType pType = (ParameterizedType) type;
>             return getTypeRelatedClass(pType.getRawType());
>         }
>         
>         if (type instanceof GenericArrayType) {
>             GenericArrayType gat = (GenericArrayType) type;
>             Type compType = gat.getGenericComponentType();             
>             Class<?> arrayBaseType = getTypeRelatedClass(compType);
>             // believe it or not, this seems to be the only way to get the
>             // Class object for an array of primitive type.
>             Object instance = Array.newInstance(arrayBaseType, 0);
>             return instance.getClass();
>         }
>         return null;
>     }
> {code}
> {color:red}
> Note: the arrayBaseType will always be null while initializing that class so 
> it will cause the next line of code NPE!!
> {color}
> Did I miss anything for this kind of class mapping while using aegis?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to