[ 
https://issues.apache.org/jira/browse/CXF-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082258#comment-14082258
 ] 

Sergey Beryozkin commented on CXF-5118:
---------------------------------------

Re CertificateMapper: I mentioned we'd possibly introduce it, so no, it is not 
an existing class.

Personally I'm not comfortable with all of this code getting into 
JAASLoginInterceptor.
You have the code doing a specific mapping from a cert subject to a user name 
which is very specific (not all certs to my knowledge would use an email 
address) and then TLSSubjectCallback having no other context but this mapped 
name which may not be sufficient in cases where no email address is used.

IMHO using a CertificateMapper (in a way suggested in the code above) offers a 
cleaner approach. CXF would have an a default CertificateMapper implementation 
which can implement your approach for the mapping, more specific 
implementations would customize it if needed, and what is more important is 
that the whole certificate info is available to custom implementations. The 
other advantage is that a password would also be retrieved in a  
CertificateMapper and thus LoginInInterceptor would work with the existing 
name/password callbacks understood by the containers. 

> Create CXF interceptor which will use HTTPS client certificates to create 
> JAAS SecurityContext 
> -----------------------------------------------------------------------------------------------
>
>                 Key: CXF-5118
>                 URL: https://issues.apache.org/jira/browse/CXF-5118
>             Project: CXF
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sergey Beryozkin
>            Assignee: Christian Schneider
>
> Use case:
> The user authenticates against the webservice using an X509 client 
> certificate. In case of successful authentication the JAAS security context 
> should be populated with a Subject that stores the user name and the roles of 
> the user. This is necessary to support Authorization at a later stage.
> Design ideas
> The SSL transport will be configured to only accept certain client 
> certificates. So we can assume that the interceptor does not have to do a 
> real authentication. Instead it has to map from the subjectDN of the 
> certificate to the user name and then lookup the roles of that user. Both 
> then has to be stored in the subject's principles.
> The mapping could be done inside a JAASLoginModule or before. Inside will 
> give the user more flexibility.
> The next step to retrieve the roles should be done in one of the standard 
> JAASLoginModules as the source of the roles can be quite diverse. So for 
> example the LdapLoginModule allows to retrieve the roles from Ldap. At the 
> moment these modules require the password of the user though which is not 
> available when doing a cert based auth.
> So I see two variants to retrieve the roles:
> 1. Change the loginmodules like the LDAP one to be configureable to use a 
> fixed ldap user for the ldap connect and not require the user password. So 
> the module would have two modes: a) normal authentication and group gathering 
> b) use a fixed user to just retrieve roles for a given user
> 2. Store the user password somewhere (e.g. in the mapping file). In this case 
> the existing LDAPLoginModule could be used but the user password would be 
> openly in a text file
> 3. Create new LoginModules with the desired behaviour (fixed user and only 
> lookup of roles)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to