[ 
https://issues.apache.org/jira/browse/CXF-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082827#comment-14082827
 ] 

Piotr Klimczak commented on CXF-5118:
-------------------------------------

So finally created hybrid solution of both our ideas.
There is no ugly TLSCallbackHandler.
Introduced CertificateMapper as requested (not used contextual thing as not 
sure what is it for, certificate mapper have to be simply set on 
JAASLoginInterceptor).
NamePasswordCallbackHandler was reused.
Looks nicer.

Take a look: 
https://github.com/PiotrKlimczak/cxf/commit/a421f46be533cdfeb02982a2f058a02536d78f94

My idea was to let it be flexible and to let it work with custom no password 
JAAS modules.
So password is not required for TLS Authenticated Messages.
What is also important, when dealing with TLS Authenticated Messages, then if 
there is AuthenticationPolicy or UsernameToken set on massages, then they take 
a precedence.
So it is possible to have both: Only TLS Authenticated and TLS Authenticated + 
Login/Password.
I have also left a possibility to specify a key from SubjectDN to simplify 
possible CertificateMapper implementation (to fit aprox 50% scenerios).

I think that now it is flexible and beautyfull enough.
Hopefully you like it too.

Starting to work with test cases

> Create CXF interceptor which will use HTTPS client certificates to create 
> JAAS SecurityContext 
> -----------------------------------------------------------------------------------------------
>
>                 Key: CXF-5118
>                 URL: https://issues.apache.org/jira/browse/CXF-5118
>             Project: CXF
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sergey Beryozkin
>            Assignee: Christian Schneider
>
> Use case:
> The user authenticates against the webservice using an X509 client 
> certificate. In case of successful authentication the JAAS security context 
> should be populated with a Subject that stores the user name and the roles of 
> the user. This is necessary to support Authorization at a later stage.
> Design ideas
> The SSL transport will be configured to only accept certain client 
> certificates. So we can assume that the interceptor does not have to do a 
> real authentication. Instead it has to map from the subjectDN of the 
> certificate to the user name and then lookup the roles of that user. Both 
> then has to be stored in the subject's principles.
> The mapping could be done inside a JAASLoginModule or before. Inside will 
> give the user more flexibility.
> The next step to retrieve the roles should be done in one of the standard 
> JAASLoginModules as the source of the roles can be quite diverse. So for 
> example the LdapLoginModule allows to retrieve the roles from Ldap. At the 
> moment these modules require the password of the user though which is not 
> available when doing a cert based auth.
> So I see two variants to retrieve the roles:
> 1. Change the loginmodules like the LDAP one to be configureable to use a 
> fixed ldap user for the ldap connect and not require the user password. So 
> the module would have two modes: a) normal authentication and group gathering 
> b) use a fixed user to just retrieve roles for a given user
> 2. Store the user password somewhere (e.g. in the mapping file). In this case 
> the existing LDAPLoginModule could be used but the user password would be 
> openly in a text file
> 3. Create new LoginModules with the desired behaviour (fixed user and only 
> lookup of roles)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to