[
https://issues.apache.org/jira/browse/CXF-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385707#comment-14385707
]
ASF GitHub Bot commented on CXF-6268:
-------------------------------------
GitHub user kops opened a pull request:
https://github.com/apache/cxf/pull/61
[CXF-6268] Make cxf-codegen-plugin toolchains aware during maven build
I reviewed PR #55 against `master`.
`javaExecutable` path resolution follows this order:
1. pom configuration: `javaExecutable` parameter
2. pom configuration: jdk toolchain
3. default value `${java.home}/bin/java`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kops/cxf feature/enable_toolchains
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit f5e61ba372d93a962c382791142b785ab105a4f6
Author: kops <[email protected]>
Date: 2015-02-25T01:16:54Z
[CXF-6268] Add toolchains support to codegen-plugin
Default behavior is modified and the javaExecutable path is resolved in the
following order:
1. a 'javaExecutable' property explicitely set is used as is ;
2. if the the toolchain manager provides a 'jdk' then it is used ;
3. fallback to default behavior: ${java.home}/bin/java.
commit fa53f4408c63e02dd2e87047bf13e8636645b8e9
Author: kops <[email protected]>
Date: 2015-03-05T22:52:04Z
[CXF-6268] Add integration test
----
> Make cxf-codegen-plugin toolchains aware during maven build
> -----------------------------------------------------------
>
> Key: CXF-6268
> URL: https://issues.apache.org/jira/browse/CXF-6268
> Project: CXF
> Issue Type: Improvement
> Affects Versions: 2.6.16, 3.0.4, 2.7.15
> Reporter: Jeremie H
>
> I'm working on a project built with Java 1.6. I though it could be a good
> idea to set up the {{maven-toolchains-plugin}}.
> Unfortunately the {{cxf-codegen-plugin}} uses the java available in the
> {{java.home}} system property. Although this can be configured with the
> {{javaExecutable}} property of the mojo, it generates configuration
> duplication.
> https://cwiki.apache.org/confluence/display/MAVENOLD/Toolchains seems to show
> an easy way to do that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
