[
https://issues.apache.org/jira/browse/CXF-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565894#comment-14565894
]
ASF GitHub Bot commented on CXF-6423:
-------------------------------------
Github user cschneider commented on the pull request:
https://github.com/apache/cxf/pull/75#issuecomment-107007358
The new code changes the behaviour for truncated messages. In the current
code the result is always well formed xml. The new code for example sometimes
omits closing tags. This is not correct.
> PrettyLoggingFilter tests and improvements
> ------------------------------------------
>
> Key: CXF-6423
> URL: https://issues.apache.org/jira/browse/CXF-6423
> Project: CXF
> Issue Type: Improvement
> Reporter: Thomas Skjølberg
> Assignee: Christian Schneider
> Priority: Minor
>
> Improvements for PrettyLoggingFilter in the cxf-rt-features-logging module:
> 1. use a StringReader instead of getting bytes from a String and using an
> InputStream (capture encoding issues at an eariler stage)
> 2. add parser exception handling based on whether the payload is truncated or
> not; return original XML if deemed invalid
> 3. do not call XMLStreamWriter.close() before getting contents for truncated
> or invalid XML because some writers misbehave (are extra helpful) in a way
> unfit for logging.
> 4.construct output StringWriter with a size based on the raw XML string size
> 5.additional test cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
