[
https://issues.apache.org/jira/browse/CXF-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider updated CXF-6424:
-------------------------------------
Comment: was deleted
(was: Github user cschneider commented on the pull request:
https://github.com/apache/cxf/pull/76#issuecomment-107007339
The new code changes the behaviour for truncated messages. In the current
code the result is always well formed xml. The new code for example sometimes
omits closing tags. This is not correct.
)
> AbstractLoggingInterceptor tests and improvements
> -------------------------------------------------
>
> Key: CXF-6424
> URL: https://issues.apache.org/jira/browse/CXF-6424
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Reporter: Thomas Skjølberg
> Priority: Minor
>
> Improvements for AbstractLoggingInterceptor:
> 1. fall back to logging raw XML payload if pretty-printing fails
> 2. ensure capacity in the output based on the raw XML string size
> 3. write directly (and improve performance) to the output StringBuilder using
> custom Writer
> 4. read directly (and improve performance) from the StringWriter buffer using
> custom Reader
> 5. contruct XMLStreamReader directly rather than going via Source
> 6. do not call XMLStreamWriter.close() before getting contents for truncated
> or invalid XML because some writers misbehave (are extra helpful) in a way
> unfit for logging.
> 7. additional javadoc / comments
> 8. additional test cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
