[
https://issues.apache.org/jira/browse/CXF-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697215#comment-14697215
]
Sergey Beryozkin commented on CXF-6540:
---------------------------------------
tokenHandlers is the private field, 'tokenValidators' is a public property.
I agree that in general it is a good practice to align the names but even if we
did align it is tokenHandlers that would need to be renamed.
I know that in most cases I did not do the aligning because typically it is not
expected to be a JAXB bean, but personally I don;t mind if Dan updates PMD
rules to enforce the aligning :-). It is a separate piece of work though...
> AbstractAccessTokenValidator property and setter out-of-sync
> ------------------------------------------------------------
>
> Key: CXF-6540
> URL: https://issues.apache.org/jira/browse/CXF-6540
> Project: CXF
> Issue Type: Bug
> Components: JAX-RS Security
> Affects Versions: 3.1.2
> Reporter: Berto Murillo
> Labels: oauth2, security
>
> The setters and the property name do not match for the following:
> Class: org.apache.cxf.rs.security.oauth2.services.AbstractAccessTokenValidator
> Property:
> {code}
> private List<AccessTokenValidator> tokenHandlers = Collections.emptyList();
> {code}
> Setter(s):
> {code}
> public void setTokenValidator(AccessTokenValidator validator) {
> setTokenValidators(Collections.singletonList(validator));
> }
>
> public void setTokenValidators(List<AccessTokenValidator> validators) {
> tokenHandlers = validators;
> for (AccessTokenValidator handler : validators) {
>
> supportedSchemes.addAll(handler.getSupportedAuthorizationSchemes());
> }
> }
> {code}
> This means you cannot set the property via the XML, although you should still
> be able to override the class, set the property, and reference the new class
> in the XML.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
