[
https://issues.apache.org/jira/browse/CXF-6729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093815#comment-15093815
]
Sergey Beryozkin commented on CXF-6729:
---------------------------------------
Hi Neal, the last patch looks better.
However - why did you add spaces everywhere, say "; Path=" ? It is allowed but
it is optional. Please remove them. The readability is of the least concern -
some clients might not be able to handle spaces.
And as I said, please keep it consistent with the original code - Version is
printed *last* there. And I see you missed 'EXPIRES' in your code. Just go via
the original code and only add mayBequote, example:
{code:java}
sb.append(value.getName()).append('=').append(maybeQuote(value.getValue()));
//and
if (value.getComment() != null) {
sb.append(';').append(COMMENT).append('=').append(maybeQuote(value.getComment()));
}
//etc
{code}
Will I update the code myself or will you create another patch ?
> Version 1 NewCookie is not compliant with RFC 2109
> ---------------------------------------------------
>
> Key: CXF-6729
> URL: https://issues.apache.org/jira/browse/CXF-6729
> Project: CXF
> Issue Type: Bug
> Components: JAX-RS
> Affects Versions: 3.0.7, 3.1.4
> Environment: Windows
> Reporter: Neal Hu
> Fix For: 3.1.5, 3.0.8
>
> Attachments: NewCookieHeaderProvider.java,
> NewCookieHeaderProvider.patch, NewCookieHeaderProviderTest.java,
> NewCookieHeaderProviderTest.patch, ResponseImplTest.java,
> ResponseImplTest.patch
>
>
> Hi,
> From http://www.ietf.org/rfc/rfc2109.txt and
> http://stackoverflow.com/questions/572482/why-do-cookie-values-with-whitespace-arrive-at-the-client-side-with-quotes
> the version 1 cookie look like: name="value with
> spaces";Max-Age=3600;Path="/";Version=1
> NewCookieHeaderProvider.toString(NewCookie) has not handled the special
> characters(RFC2068) that need around with quotes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
