[
https://issues.apache.org/jira/browse/CXF-6869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320207#comment-15320207
]
Vedran Pavic commented on CXF-6869:
-----------------------------------
Hey Sergey,
{quote}
If we have a property approach, I believe the only thing which would change as
far as your last patch is concerned, is that instead we'd have Conditional
checking the property is set, right ?
{quote}
Correct, instead of {{@ConditionalOnMissingBean(name = "jaxRsServer")}} you'd
put {{@ConditionalOnProperty(prefix = "cxf", name = "jax-rs.component-scan",
havingValue = "true")}}.
{quote}
What I did not quite get, I tried a jaxws demo with your patch which enables
the jaxrs auto discovery and it worked fine without me adding a JAX-RS dep, how
does it work if the auto-configure feature has Conditional on
JAXRSServerFactoryBean.class ?
{quote}
The JAX-WS demo? Or did you meant to say JAX-RS demo? In any case can you point
me to the concrete project we're talking about here?
If it's the JAX-RS demo, the dependency comes via
{{cxf-spring-boot-starter-jaxrs}}. Otherwise something else must be
(transitively) pulling the JAX-RS components.
> Consider adding Spring Boot starter
> -----------------------------------
>
> Key: CXF-6869
> URL: https://issues.apache.org/jira/browse/CXF-6869
> Project: CXF
> Issue Type: New Feature
> Components: Integration
> Reporter: Vedran Pavic
> Assignee: Sergey Beryozkin
>
> I've recently authored a PR in Spring Boot to add support for
> auto-configuration of {{CXFServlet}} and default CXF's configuration:
> https://github.com/spring-projects/spring-boot/pull/5659
> The PR was closed with "won't fix" resolution since Boot team are unwilling
> to add CXF as a dependency to the project. Instead a 3rd party starter was
> suggested.
> The concept of a 3rd party starter is generally encouraged for technologies
> that don't have first-class support in projects from Spring portfolio. Such
> 3rd party starters are listed here:
> https://github.com/spring-projects/spring-boot/blob/master/spring-boot-starters/README.adoc
> If CXF team is interested, I'm willing to port my PR to CXF.
> Note that the original PR was focused around JAX-WS support, but can be
> easily expanded to include JAX-RS support as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
