[
https://issues.apache.org/jira/browse/CXF-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470170#comment-15470170
]
Sergey Beryozkin commented on CXF-7042:
---------------------------------------
Hi Romain,
Yes, not a bug, but it did get my attention :-;
I'm not seeing where a JAX-RS spec mandates the clients are thread safe; CXF
adds a thread-local map to make it happen and the thread local data are
recycled only if the user code is explicitly doing .reset() or a background
thread is enabled to do the clean up. Besides many clients a main() clients
which do not need a thread-safety. So IMHO it should not become a default.
We had a lot of side-effects with a header.split, especially with Cookies
(Expires would have ',') and I believe few other headers.
Can you please type a Link header value which is not processed correctly ?
And let me know how the client code accesses this Link, as Response.getLink()
or Response.getHeader() ?
thanks
> review some jaxrs client defaults: thread safe and split headers
> ----------------------------------------------------------------
>
> Key: CXF-7042
> URL: https://issues.apache.org/jira/browse/CXF-7042
> Project: CXF
> Issue Type: Bug
> Reporter: Romain Manni-Bucau
>
> Hi
> putting it as "bug" but can be "improvement" depending how you see it
> I'd like we take a moment to review 2 properties of the client:
> - thread.safe.client: i think the default should be true since the spec is
> thread safe
> - org.apache.cxf.http.header.split (AbstractClient): issue not being true by
> default is it breaks some natural JAXRS round trips like Link: your server
> sends Link header with 2 values, client (response.getLinks()) is not able to
> read it. If it is about performances, known headers (the ones wrapped by some
> higher level API in JAXRS) should at least be handled properly by default.
> Side note for headers: org.apache.cxf.transport.http.Headers#copyToResponse
> concatenate headers properly for multiple values but not for Link header
> cause of
> org.apache.cxf.transport.http.Headers#HTTP_HEADERS_SINGLE_VALUE_ONLY, not
> sure it is intended
> wdyt?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
