[
https://issues.apache.org/jira/browse/CXF-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070347#comment-16070347
]
Stefan E. Funk commented on CXF-7042:
-------------------------------------
Is it possible that line (349 I guess)
Integer cleanupPeriod = getIntValue(configProps.get(THREAD_SAFE_CLIENT_PROP));
in
http://cxf.547215.n5.nabble.com/cxf-git-commit-CXF-7042-Supporting-system-thread-safe-properties-td5772355.html
should be
Integer cleanupPeriod =
getIntValue(configProps.get(THREAD_SAFE_CLIENT_STATE_CLEANUP_PERIOD));
? Have a nice weekend! Just noticed that updating from 3.1.7 to 3.1.8… I got a
java.lang.NumberFormatException: For input string: "true"
at
java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:580)
at java.lang.Integer.valueOf(Integer.java:766)
at
org.apache.cxf.jaxrs.client.spec.ClientImpl.getIntValue(ClientImpl.java:553)
at
org.apache.cxf.jaxrs.client.spec.ClientImpl.access$400(ClientImpl.java:52)
at
org.apache.cxf.jaxrs.client.spec.ClientImpl$WebTargetImpl.initTargetClientIfNeeded(ClientImpl.java:349)
at
org.apache.cxf.jaxrs.client.spec.ClientImpl$WebTargetImpl.request(ClientImpl.java:260)
> review some jaxrs client defaults: thread safe and split headers
> ----------------------------------------------------------------
>
> Key: CXF-7042
> URL: https://issues.apache.org/jira/browse/CXF-7042
> Project: CXF
> Issue Type: Bug
> Components: JAX-RS
> Reporter: Romain Manni-Bucau
>
> Hi
> putting it as "bug" but can be "improvement" depending how you see it
> I'd like we take a moment to review 2 properties of the client:
> - thread.safe.client: i think the default should be true since the spec is
> thread safe
> - org.apache.cxf.http.header.split (AbstractClient): issue not being true by
> default is it breaks some natural JAXRS round trips like Link: your server
> sends Link header with 2 values, client (response.getLinks()) is not able to
> read it. If it is about performances, known headers (the ones wrapped by some
> higher level API in JAXRS) should at least be handled properly by default.
> Side note for headers: org.apache.cxf.transport.http.Headers#copyToResponse
> concatenate headers properly for multiple values but not for Link header
> cause of
> org.apache.cxf.transport.http.Headers#HTTP_HEADERS_SINGLE_VALUE_ONLY, not
> sure it is intended
> wdyt?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
