[ 
https://issues.apache.org/jira/browse/DOSGI-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085138#comment-16085138
 ] 

ASF GitHub Bot commented on DOSGI-267:
--------------------------------------

GitHub user badfish69 opened a pull request:

    https://github.com/apache/cxf-dosgi/pull/3

    [DOSGI-267] Treat all intents annotated with @Provider as providers

    Currently a static list of classes is used to determine if a given intent 
is treated as a provider.  This patch allows any class with the @Provider 
annotation to be treated as one.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/badfish69/cxf-dosgi DOSGI-267

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf-dosgi/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3
    
----
commit bf243bd129d1191c9ba325d5a163d3d29707461f
Author: Richard Begg <[email protected]>
Date:   2017-07-13T03:38:20Z

    [DOSGI-267] Treat all intents annotated with @Provider as providers

----


> ContainerRequestFilter intents do not get registered as providers
> -----------------------------------------------------------------
>
>                 Key: DOSGI-267
>                 URL: https://issues.apache.org/jira/browse/DOSGI-267
>             Project: CXF Distributed OSGi
>          Issue Type: Bug
>          Components: provider-rs
>    Affects Versions: 2.1.0, 2.2.0
>            Reporter: Richard Begg
>            Assignee: Christian Schneider
>            Priority: Minor
>             Fix For: 2.3.0
>
>         Attachments: use_provider_annotation.patch
>
>
> Intents of ContainerRequestFilter (or ContainerResponseFilter) type do not 
> automatically get registered as JAX-RS providers in the same way as 
> MessageBodyReader or other provider types.
> This is due to a hard-coded list of classes in the isProvider() method in 
> provider-rs/src/main/java/org/apache/cxf/dosgi/dsw/handlers/rest/RsProvider.java
> Now we could just add the filter classes to the list, but I'm wondering why 
> we don't just look for the @Provider annotation instead?  That way, it should 
> work for everything (assuming people correctly annotate their provider 
> classes).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to