[
https://issues.apache.org/jira/browse/CXF-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109238#comment-16109238
]
ASF GitHub Bot commented on CXF-7462:
-------------------------------------
GitHub user andymc12 opened a pull request:
https://github.com/apache/cxf/pull/301
[CXF-7462] Minor improvements to OutboundSseEventImpl
1) Make the fields final to reflect that the event is immutable.
2) Use defaults for the data type (String.class) and media type
(SERVER_SENT_EVENT_TYPE).
3) Restrict the constructor's visibility.
New tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andymc12/cxf experiment-sse
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #301
----
commit 02f7a8b330ded2e97d7920529644433b4b6ac87f
Author: Andy McCright <[email protected]>
Date: 2017-08-01T16:32:40Z
[CXF-7462] Minor improvements to OutboundSseEventImpl
1) Make the fields final to reflect that the event is immutable.
2) Use defaults for the data type (String.class) and media type
(SERVER_SENT_EVENT_TYPE).
3) Restrict the constructor's visibility.
New tests.
----
> OutboundSseEventImpl could use some minor tweaks
> ------------------------------------------------
>
> Key: CXF-7462
> URL: https://issues.apache.org/jira/browse/CXF-7462
> Project: CXF
> Issue Type: Improvement
> Components: JAX-RS
> Affects Versions: 3.2.0
> Reporter: Andy McCright
> Priority: Minor
> Fix For: 3.2.0
>
>
> The OutboundSseEventImpl class could use some minor tweaks, including:
> 1) Make the fields final to reflect that the event is immutable.
> 2) Use defaults for the data type (String.class) and media type
> (SERVER_SENT_EVENT_TYPE).
> 3) Restrict the constructor's visibility.
> I also plan to add some tests for these changes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
