[ 
https://issues.apache.org/jira/browse/CXF-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114232#comment-16114232
 ] 

Dennis Kieselhorst commented on CXF-7464:
-----------------------------------------

[~ffang] the plugin works great so far.

I just changed the defaults for version, title and description. Now the values 
from the pom are used, in my view this makes more sense.

Some points for discussion:
* I would leave host empty by default instead of using some nonsense value.
* Schemes are set to http/ https by default, this is not the case when using 
Swagger2Feature, so I would leave them empty too.
* I would not set contact name and url hardcoded without possibility to change, 
empty should be also fine here.
* It would be great to pass/ scan an existing Swagger2Feature class as there 
might one in the project which already has all properties set.

what do you think?

> add java2swagger maven plugin so that can generate swagger(json/yaml) during 
> build time
> ---------------------------------------------------------------------------------------
>
>                 Key: CXF-7464
>                 URL: https://issues.apache.org/jira/browse/CXF-7464
>             Project: CXF
>          Issue Type: New Feature
>          Components: Tooling
>            Reporter: Freeman Fang
>            Assignee: Freeman Fang
>             Fix For: 3.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to