[
https://issues.apache.org/jira/browse/CXF-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225712#comment-16225712
]
Andriy Redko commented on CXF-7501:
-----------------------------------
I really appreciate your insights, no doubts about that, thank a lot for
sharing them :-) I think that many people, you and myself included, concerned
that there is an overlap between @Context and @Inject, and this is indeed an
issue. Having one mechanism would benefit all, now when CDI officially supports
SE, things may be easier in fact. Not sure what to do in case of Spring /
unmanaged runtimes?
To be honest, I started with ConfigurableFactory first :-D But than I added the
list of internal server-side providers to register (so not to copy/paste them
around) and discovered we have similar implementation for the client. So it
forced me to go with ServerConfigurableFactory and (future)
ClientConfigurableFactory. Functionally they might be similar but there are
differences on the conceptual level, like providers f.e., I didn't want to mix
them together. I think we could always refine the implementation later on. What
do you think?
> Cannot inject field in ContainerRequestFilter
> ---------------------------------------------
>
> Key: CXF-7501
> URL: https://issues.apache.org/jira/browse/CXF-7501
> Project: CXF
> Issue Type: Bug
> Components: JAX-RS
> Affects Versions: 3.1.10, 3.2.0
> Environment: Linux Mint 64 bit, TomEE Plus 7.0.3, JavaEE 7
> application using MVC specification and reference implementation(Libs
> Attached)
> Reporter: Jeyvison Nascimento
> Assignee: Andriy Redko
> Labels: cdi
> Fix For: 3.1.14, 3.2.1
>
> Attachments: javax-mvc.jar, ozark.jar
>
>
> Hey folks.
> We found a weird behavior while running MVC specification(JSR 371) on TomEE
> witch CXF. We have a *ContainerRequestFilter* defined called
> *JaxRsContextFilter*
> {code:java}
> @PreMatching
> @Priority(0)
> public class JaxRsContextFilter implements ContainerRequestFilter {
> @Inject
> private JaxRsContextProducer jaxRsContextProducer;
> @Context
> private Configuration configuration;
> @Context
> private HttpServletRequest request;
> @Context
> private HttpServletResponse response;
> public JaxRsContextFilter() {
> }
> public void filter(ContainerRequestContext requestContext) throws
> IOException {
> this.jaxRsContextProducer.populate(this.configuration, this.request,
> this.response);
> }
> }
> {code}
> You can see that we have a JaxRsContextProducer annotated to be injected as a
> field in our object but when JAXRSUtils is called to run the the container
> filters it injects the fields annotated as *@Context* , not the fields
> annotated with *@Inject*.
> {code:java}
> for (ProviderInfo<ContainerRequestFilter> filter : containerFilters) {
> try {
> InjectionUtils.injectContexts(filter.getProvider(),
> filter, m);
> filter.getProvider().filter(context);
> } catch (IOException ex) {
> throw ExceptionUtils.toInternalServerErrorException(ex,
> null);
> }
> {code}
> It causes our filter(*JaxRsContextFilter*) to throw a NullPointerException
> when filtering the request because it uses the producer to perform some
> actions in this operation.
> I believe this field should be injected as well, not only the *@Context*
> fields.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
