[
https://issues.apache.org/jira/browse/CXF-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283862#comment-16283862
]
ASF GitHub Bot commented on CXF-7470:
-------------------------------------
dkulp closed pull request #342: [CXF-7470] Cannot set target for recovered
source sequence
URL: https://github.com/apache/cxf/pull/342
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/SourceSequence.java
b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/SourceSequence.java
index f4b610f6330..b0dbbc7f520 100644
--- a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/SourceSequence.java
+++ b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/SourceSequence.java
@@ -271,13 +271,13 @@ SequenceAcknowledgement getAcknowledgement() {
*
* @param to
*/
- synchronized void setTarget(EndpointReferenceType to) {
+ public synchronized void setTarget(EndpointReferenceType to) {
if (target == null && !ContextUtils.isGenericAddress(to)) {
target = to;
}
}
- synchronized EndpointReferenceType getTarget() {
+ public synchronized EndpointReferenceType getTarget() {
return target;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> WSRM - Cannot set target for recovered source sequence
> ------------------------------------------------------
>
> Key: CXF-7470
> URL: https://issues.apache.org/jira/browse/CXF-7470
> Project: CXF
> Issue Type: Bug
> Components: WS-* Components
> Affects Versions: 3.1.12
> Reporter: Gergan Dimitrov
> Priority: Critical
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When source sequence is recovered during client creation, we cannot set the
> target property, as its setter method is package private. If we have sequence
> with only one message, and we get acknowledgment for the last message, in the
> SourceSequence.setAcknowledged(...) method, there is a check on line 167:
> if (null == target....)
> As the target is null, the api does not automatically send close and
> terminate sequence messages.
> So several options here:
> 1) Make the setTarget method public, or at least protected
> 2) Allow setting the property from constructor
> 3) Set the property from current endpoint's URL, during recovery.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
