[ 
https://issues.apache.org/jira/browse/CXF-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434098#comment-16434098
 ] 

ASF GitHub Bot commented on CXF-7695:
-------------------------------------

dkulp closed pull request #399: CXF-7695 wsdl2java client jar generation fails 
if jaxws binding is used
URL: https://github.com/apache/cxf/pull/399
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/customization/JAXWSBindingSerializer.java
 
b/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/customization/JAXWSBindingSerializer.java
new file mode 100644
index 00000000000..af498815743
--- /dev/null
+++ 
b/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/customization/JAXWSBindingSerializer.java
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.cxf.tools.wsdlto.frontend.jaxws.customization;
+
+import java.io.*;
+
+import javax.wsdl.Definition;
+import javax.wsdl.WSDLException;
+import javax.wsdl.extensions.ExtensibilityElement;
+import javax.wsdl.extensions.ExtensionRegistry;
+import javax.wsdl.extensions.ExtensionSerializer;
+import javax.xml.namespace.QName;
+
+public class JAXWSBindingSerializer implements ExtensionSerializer, 
Serializable {
+    public static final long serialVersionUID = 1;
+
+    public void marshall(@SuppressWarnings("rawtypes") Class parentType,
+                         QName elementType,
+                         ExtensibilityElement extension,
+                         PrintWriter pw,
+                         Definition def,
+                         ExtensionRegistry extReg)
+        throws WSDLException {
+        // This class is needed to generate the WSDL file included in the 
client jar. 
+        // It simply ignores the JAXWS Binding when generating the WSDL file. 
+    }
+}
diff --git 
a/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/wsdl11/JAXWSDefinitionBuilder.java
 
b/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/wsdl11/JAXWSDefinitionBuilder.java
index 77e5cb81e22..9bcba862563 100644
--- 
a/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/wsdl11/JAXWSDefinitionBuilder.java
+++ 
b/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/wsdl11/JAXWSDefinitionBuilder.java
@@ -55,6 +55,7 @@
 import 
org.apache.cxf.tools.wsdlto.frontend.jaxws.customization.CustomizationParser;
 import org.apache.cxf.tools.wsdlto.frontend.jaxws.customization.JAXWSBinding;
 import 
org.apache.cxf.tools.wsdlto.frontend.jaxws.customization.JAXWSBindingDeserializer;
+import 
org.apache.cxf.tools.wsdlto.frontend.jaxws.customization.JAXWSBindingSerializer;
 import org.apache.cxf.wsdl.WSDLManager;
 
 public class JAXWSDefinitionBuilder extends AbstractWSDLBuilder {
@@ -99,6 +100,7 @@ private void registerJaxwsExtension(ExtensionRegistry 
registry) {
     }
 
     private void registerJAXWSBinding(ExtensionRegistry registry, Class<?> 
clz) {
+        registry.registerSerializer(clz, ToolConstants.JAXWS_BINDINGS, new 
JAXWSBindingSerializer());
         registry.registerDeserializer(clz, ToolConstants.JAXWS_BINDINGS, new 
JAXWSBindingDeserializer());
         registry.mapExtensionTypes(clz, ToolConstants.JAXWS_BINDINGS, 
JAXWSBinding.class);
     }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> wsdl2java client jar generation fails if jaxws binding is used
> --------------------------------------------------------------
>
>                 Key: CXF-7695
>                 URL: https://issues.apache.org/jira/browse/CXF-7695
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 3.2.4
>            Reporter: Reto Weiss
>            Assignee: Daniel Kulp
>            Priority: Major
>         Attachments: StockQuoteService.xml, noWrappersBinding.xml
>
>
> The following exception is thrown by wsdl2java tool if I use option 
> -clientjar and my wsdl contains a jaxws binding. The same error also happens 
> if I use wsdl without jaxws binding but  provide a jaxws binding file with 
> option -b:
> {code:java}
> C:\Tools\apache-cxf-3.2.4\bin>wsdl2java -d out -clientjar client.jar 
> jxb/StockQuoteService.xml
> Apr 03, 2018 3:15:49 PM org.apache.cxf.tools.wsdlto.WSDLToJavaContainer 
> generateLocalWSDL
> SCHWERWIEGEND: Failed to generate local wsdl for clientjar
> java.lang.ClassCastException: 
> org.apache.cxf.tools.wsdlto.frontend.jaxws.customization.JAXWSBinding cannot 
> be cast to javax.wsdl.extensions.UnknownExtensibilityElement
>         at 
> javax.wsdl.extensions.UnknownExtensionSerializer.marshall(UnknownExtensionSerializer.java:34)
>         at 
> com.ibm.wsdl.xml.WSDLWriterImpl.printExtensibilityElements(WSDLWriterImpl.java:998)
>         at 
> com.ibm.wsdl.xml.WSDLWriterImpl.printPortTypes(WSDLWriterImpl.java:474)
>         at 
> com.ibm.wsdl.xml.WSDLWriterImpl.printDefinition(WSDLWriterImpl.java:133)
>         at com.ibm.wsdl.xml.WSDLWriterImpl.writeWSDL(WSDLWriterImpl.java:1073)
>         at com.ibm.wsdl.xml.WSDLWriterImpl.writeWSDL(WSDLWriterImpl.java:1098)
>         at 
> org.apache.cxf.tools.wsdlto.WSDLToJavaContainer.generateLocalWSDL(WSDLToJavaContainer.java:833)
>         at 
> org.apache.cxf.tools.wsdlto.WSDLToJavaContainer.processClientJar(WSDLToJavaContainer.java:348)
>         at 
> org.apache.cxf.tools.wsdlto.WSDLToJavaContainer.processWsdl(WSDLToJavaContainer.java:314)
>         at 
> org.apache.cxf.tools.wsdlto.WSDLToJavaContainer.execute(WSDLToJavaContainer.java:164)
>         at 
> org.apache.cxf.tools.wsdlto.WSDLToJavaContainer.execute(WSDLToJavaContainer.java:412)
>         at 
> org.apache.cxf.tools.common.toolspec.ToolRunner.runTool(ToolRunner.java:105)
>         at org.apache.cxf.tools.wsdlto.WSDLToJava.run(WSDLToJava.java:113)
>         at org.apache.cxf.tools.wsdlto.WSDLToJava.run(WSDLToJava.java:86)
>         at org.apache.cxf.tools.wsdlto.WSDLToJava.main(WSDLToJava.java:185)
> WSDLToJava Error: Failed to generate local wsdl for clientjar
> {code}
> This works fine with 3.1.9. Seems the error was introduced by commit: 
> bcb6385a095dcaaf8390ecfc33e9e22b9149daad
> because the class JAXWSBindingSerializer was deleted and removed from class 
> JAXWSDefinitionBuilder.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to