[
https://issues.apache.org/jira/browse/CXF-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451340#comment-16451340
]
ASF GitHub Bot commented on CXF-7716:
-------------------------------------
WhiteCat22 commented on a change in pull request #407: [CXF-7716] Reduce
StringBuilders and other performance changes.
URL: https://github.com/apache/cxf/pull/407#discussion_r183899002
##########
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
##########
@@ -1508,11 +1509,40 @@ public static boolean matchMimeTypes(MediaType
requestContentType,
}
}
}
-
return new ArrayList<>(supportedMimeTypeList);
+ }
+
+ public static boolean doMimeTypesIntersect(List<MediaType>
requiredMediaTypes, List<MediaType> userMediaTypes) {
+ for (MediaType requiredType : requiredMediaTypes) {
Review comment:
This makes sense, but is there another interface that we can use instead of
BiConsumer? BiConsumer requires Java 1.8 and this is something that we would
like to see backported to 3.1.X which has 1.7 dependencies. Another thing is
that we need to have a mechanism to return after the first match during
NonAccumulatingConsumer .accept() instead of going through the entire double
for loops. There are several ways to do this, pass in a flag to allow us to
bail out after first match, return a boolean from accept, or create a new
isFinished() method to let us know that we are done processing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> IBM Performance Team has found several performance increases
> ------------------------------------------------------------
>
> Key: CXF-7716
> URL: https://issues.apache.org/jira/browse/CXF-7716
> Project: CXF
> Issue Type: Bug
> Components: JAX-RS
> Affects Versions: 3.0.15, 3.2.4
> Reporter: Adam Anderson
> Priority: Major
> Fix For: 3.2.5
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Our performance team has identified several areas of improvement to reduce
> garbage collection and CPU usage.
> First, we reduced the amount of StringBuilders created in HTTPUtils.java and
> ResourceUtils.java.
> Second, we created JAXRSUtils.doMimeTypesIntersect() - a method similar to
> JAXRSUtils.intersectMimeTypes - that doesn't create a HashSet but instead
> returns a boolean when we just need to know if they intersect.
> Third, we found that getting the annotations for parameters to create
> constructor arguments in PerRequestResourceProvider.java is expensive, so we
> cache them in the constructor instead of getting them via reflection every
> request.
> These changes combined result in a ~1.5-2% performance increase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
