[ 
https://issues.apache.org/jira/browse/CXF-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519242#comment-16519242
 ] 

Colm O hEigeartaigh commented on CXF-7765:
------------------------------------------

There is definitely a bug there, but I'm not sure about the suggested fix - it 
removes the check for String equality on the literalChars that is currently 
there and replaces it with a comparison on the length of the literalChars. A 
better idea might be to compare the literalChars using String.compareTo instead.

> UrlTemplate.compareTemplates returns inconsistent results
> ---------------------------------------------------------
>
>                 Key: CXF-7765
>                 URL: https://issues.apache.org/jira/browse/CXF-7765
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.1.15
>            Reporter: Shon Vella
>            Priority: Major
>
> When org.apache.cxf.jaxrs.model.URITemplate.compareTemplates() is passed two 
> templates with the same number of literal characters, it returns -1 
> regardless of the order the templates a passed in. I suppose this may be on 
> purpose, but the result is that if compareTemplates() is used as the basis of 
> a Comparator<URITemplate> that is used by java.util.Collections.sort() it can 
> result in:
> {{java.lang.IllegalArgumentException: Comparison method violates its general 
> contract!}}
> I would also expect that this would result in some degree if unpredictability 
> of the prioritization of when selecting the appropriate JAX-RS method to call 
> for a give request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to