[
https://issues.apache.org/jira/browse/CXF-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614765#comment-16614765
]
Adrian Cole commented on CXF-7792:
----------------------------------
The short of it was that he was trying to make http calls and it was clear
those calls weren't being traced. It was hard to decipher what was working
because in OSGi I assumed the brave.Tracing or brave.HttpTracing would have
been supplied by the OSGi context, yet in some copy/paste examples it
seemed like the user was duplicating that config (which would cause traces
to break). I think the other jira on making spring beans work, and default
to a real zipkin server will help with some of this.
After that, I'm mostly interested in getting this to a point where we can
make a brave-cxf-example repo similar to
https://github.com/openzipkin/sleuth-webmvc-example. This would be based on
a cxf 3.3 release as I don't really want to invest backwards until at least
current stuff works fine. This might mean that the servicemix specific part
of this is out of scope at least temporarily (for me)
The main goal for me is to be able to learn how to swap out jax-rs client
for apachehc as that's where this topic melted down. For example, there's a
brave-instrumentation-httpclient module which isn't currently
pre-configured with cxf. It isn't a complicated setup, it just uses the
same HttpTracing instance everything else does. Lacking a shared example
with the user led to a lot of guessing and confusion.
So, it would be good to know how to add apachehc to karaf (cxf) such that
it uses the HttpTracing instance provided by OSGi. If we had a
brave-cxf-example repo it could end up materialized as a diff like this
https://github.com/openzipkin/sleuth-webmvc-example/compare/add-dubbo-tracing
These sort of things are easier for me to help folks troubleshoot as you
can easily return to the known working base and only introduce a minimal
change.
All that said, I think your docs are good and better than most, and
probably fine for folks more versed, just looking to find ways to help
reduce the load as this last couple days hurt a lot (not to mention the
"hurt" you'all had earlier!). Thanks again!
> Distributed Tracing with OpenZipkin Brave and OSGi
> --------------------------------------------------
>
> Key: CXF-7792
> URL: https://issues.apache.org/jira/browse/CXF-7792
> Project: CXF
> Issue Type: Wish
> Components: Tracing Brave
> Affects Versions: 3.2.5
> Reporter: bambus
> Priority: Critical
> Attachments: image-2018-07-25-09-01-33-506.png,
> image-2018-07-30-13-04-31-402.png, image-2018-07-31-10-15-37-839.png,
> jaxws_tracing_brave_osgi.zip
>
>
> I have followed your example and brave example for implementing brave in cxf
> based application. After I added brave I could not package it like bundle. I
> always get different errors. Error like: Caused by:
> java.lang.NoClassDefFoundError: zipkin/reporter/Reporter
> Another one: Caused by: java.lang.ClassCastException: Cannot cast
> org.apache.cxf.service.factory.FactoryBeanListenerManager to
> org.apache.cxf.service.factory.FactoryBeanListenerManager
> I am using Service Mix 7.0.1 with Karaf 4.0.9.
> Can you help me how to pack it like as a bundle.
> In this example that thing is missing:
>
> [https://cwiki.apache.org/confluence/display/CXF20DOC/Using+OpenZipkin+Brave#UsingOpenZipkinBrave-SpringXML-Configuration]
> I have configured the blueprint like in the example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
