[
https://issues.apache.org/jira/browse/CXF-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623504#comment-16623504
]
Andriy Redko commented on CXF-7844:
-----------------------------------
[~adriancole] Did a first batch of changes into master, unfortunately using
spring-beans or spring-reporter-beans is not an option for OSGi unless we bring
the bunch of Spring Frameworks deps (these modules depend on Spring Context at
least). I have used more application-side approach but I think it is fine.
Tested on Karaf 4.1.x and Karaf 4.2.x, all spans end up in Zipkin
(https://github.com/apache/cxf/commit/f4dbb3b335e7e06a4fb03fcf2aa170af2b3b0298)
Will be porting the changes to 3.2.x and 3.1.x, those use a bit older versions
of Brave.
> Change Zipkin/Brave XML to use brave-spring-beans
> -------------------------------------------------
>
> Key: CXF-7844
> URL: https://issues.apache.org/jira/browse/CXF-7844
> Project: CXF
> Issue Type: Improvement
> Components: Tracing Brave
> Reporter: Adrian Cole
> Assignee: Andriy Redko
> Priority: Major
>
> I noticed the sample projects don't connect to any server. This could make it
> hard for someone to get started. Also, the XML beans don't use the helpers
> that exist in brave.
> https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jax_rs/tracing_brave
> https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jax_rs/tracing_brave_osgi
> https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jaxws_tracing_brave_osgi
> Could these be changed to use brave-spring-beans? or otherwise make a
> functional tracer?
> https://github.com/openzipkin/brave/tree/master/spring-beans
> Here are some example configurations:
> https://github.com/openzipkin/brave-webmvc-example/blob/master/webmvc3/src/main/webapp/WEB-INF/applicationContext.xml
> https://github.com/openzipkin/brave-webmvc-example/blob/master/webmvc4-boot/src/main/java/brave/webmvc/TracingConfiguration.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
