[
https://issues.apache.org/jira/browse/CXF-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646152#comment-16646152
]
ASF GitHub Bot commented on CXF-7867:
-------------------------------------
coheigea commented on a change in pull request #456: CXF-7867 - Allow the
AbstractSpnegoAuthSupplier loginConfig to be used
URL: https://github.com/apache/cxf/pull/456#discussion_r224367691
##########
File path:
rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/AbstractSpnegoAuthSupplier.java
##########
@@ -120,6 +120,10 @@ public String getAuthorization(AuthorizationPolicy
authPolicy,
lc.login();
subject = lc.getSubject();
}
+ } else if (loginConfig != null) {
Review comment:
I think maybe we should check if delegratedCred == null here as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> LoginConfig in AbstractSpnegoAuthSupplier is not used
> -----------------------------------------------------
>
> Key: CXF-7867
> URL: https://issues.apache.org/jira/browse/CXF-7867
> Project: CXF
> Issue Type: Bug
> Components: Transports
> Reporter: Nicholas DiPiazza
> Assignee: Freeman Fang
> Priority: Minor
>
> We allow users to set the loginConfig in the AbstractSpnegoAuthSupplier
> But we do not use it. See:
> https://github.com/apache/cxf/blob/master/rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/AbstractSpnegoAuthSupplier.java#L116
> for its only usage.
> Unless I'm not understanding something, we should allow people to use it.
> Possibly naive PR: https://github.com/apache/cxf/pull/456
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
