[
https://issues.apache.org/jira/browse/CXF-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651768#comment-16651768
]
ASF GitHub Bot commented on CXF-7878:
-------------------------------------
coheigea closed pull request #460: CXF-7878: ClientPolicyCalculator ignores
ConnectionRequestTimeout property
URL: https://github.com/apache/cxf/pull/460
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/rt/transports/http/src/main/java/org/apache/cxf/transport/http/policy/impl/ClientPolicyCalculator.java
b/rt/transports/http/src/main/java/org/apache/cxf/transport/http/policy/impl/ClientPolicyCalculator.java
index 629bcacc51e..b934dc5a9b6 100644
---
a/rt/transports/http/src/main/java/org/apache/cxf/transport/http/policy/impl/ClientPolicyCalculator.java
+++
b/rt/transports/http/src/main/java/org/apache/cxf/transport/http/policy/impl/ClientPolicyCalculator.java
@@ -67,6 +67,7 @@ public boolean equals(HTTPClientPolicy p1, HTTPClientPolicy
p2) {
&& (p1.isSetProxyServerPort() ? p1.getProxyServerPort() ==
p2.getProxyServerPort() : !p2
.isSetProxyServerPort())
&&
p1.getProxyServerType().value().equals(p2.getProxyServerType().value())
+ && (p1.getConnectionRequestTimeout() ==
p2.getConnectionRequestTimeout())
&& (p1.getReceiveTimeout() == p2.getReceiveTimeout())
&& StringUtils.equals(p1.getReferer(), p2.getReferer());
@@ -141,6 +142,11 @@ public HTTPClientPolicy intersect(HTTPClientPolicy p1,
HTTPClientPolicy p2) {
} else if (p2.isSetConnectionTimeout()) {
p.setConnectionTimeout(p2.getConnectionTimeout());
}
+ if (p1.isSetConnectionRequestTimeout()) {
+ p.setConnectionRequestTimeout(p1.getConnectionRequestTimeout());
+ } else if (p2.isSetConnectionRequestTimeout()) {
+ p.setConnectionRequestTimeout(p2.getConnectionRequestTimeout());
+ }
if (p1.isSetReceiveTimeout()) {
p.setReceiveTimeout(p1.getReceiveTimeout());
} else if (p2.isSetReceiveTimeout()) {
diff --git
a/rt/transports/http/src/test/java/org/apache/cxf/transport/http/policy/ClientPolicyCalculatorTest.java
b/rt/transports/http/src/test/java/org/apache/cxf/transport/http/policy/ClientPolicyCalculatorTest.java
index af7d68b73be..348eddfa380 100644
---
a/rt/transports/http/src/test/java/org/apache/cxf/transport/http/policy/ClientPolicyCalculatorTest.java
+++
b/rt/transports/http/src/test/java/org/apache/cxf/transport/http/policy/ClientPolicyCalculatorTest.java
@@ -18,6 +18,8 @@
*/
package org.apache.cxf.transport.http.policy;
+import java.util.concurrent.ThreadLocalRandom;
+
import org.apache.cxf.transport.http.policy.impl.ClientPolicyCalculator;
import org.apache.cxf.transports.http.configuration.HTTPClientPolicy;
@@ -46,6 +48,7 @@ public void testCompatibleClientPolicies() {
@Test
public void testIntersectClientPolicies() {
+ ThreadLocalRandom random = ThreadLocalRandom.current();
ClientPolicyCalculator calc = new ClientPolicyCalculator();
HTTPClientPolicy p1 = new HTTPClientPolicy();
HTTPClientPolicy p2 = new HTTPClientPolicy();
@@ -55,9 +58,22 @@ public void testIntersectClientPolicies() {
p = calc.intersect(p1, p2);
assertEquals("browser", p.getBrowserType());
p1.setBrowserType(null);
- p1.setConnectionTimeout(10000L);
+
+ long connectionRequestTimeout = random.nextLong(0, 10000);
+ p1.setConnectionRequestTimeout(connectionRequestTimeout);
+ p = calc.intersect(p1, p2);
+ assertEquals(connectionRequestTimeout,
p.getConnectionRequestTimeout());
+
+ long receiveTimeout = random.nextLong(0, 10000);
+ p1.setReceiveTimeout(receiveTimeout);
p = calc.intersect(p1, p2);
- assertEquals(10000L, p.getConnectionTimeout());
+ assertEquals(receiveTimeout, p.getReceiveTimeout());
+
+ long connectionTimeout = random.nextLong(0, 10000);
+ p1.setConnectionTimeout(connectionTimeout);
+ p = calc.intersect(p1, p2);
+ assertEquals(connectionTimeout, p.getConnectionTimeout());
+
p1.setAllowChunking(false);
p2.setAllowChunking(false);
p = calc.intersect(p1, p2);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ClientPolicyCalculator ignores ConnectionRequestTimeout property
> ----------------------------------------------------------------
>
> Key: CXF-7878
> URL: https://issues.apache.org/jira/browse/CXF-7878
> Project: CXF
> Issue Type: Bug
> Components: Transports
> Affects Versions: 3.2.6
> Reporter: Györgyey Tamás
> Assignee: Colm O hEigeartaigh
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.2.7
>
>
> ClientPolicyCalculator#intersect() drops the value set with
> setConnectionRequestTimeout() from the returned policy. As a result,
> AsyncHttpConduit always uses the default value even if it is explicitly set
> by the user through a HTTPClientPolicy.
> PR on GitHub: https://github.com/apache/cxf/pull/460
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
