[
https://issues.apache.org/jira/browse/CXF-8170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987708#comment-16987708
]
Ben M. commented on CXF-8170:
-----------------------------
[~reta] here you go: [https://github.com/apache/cxf/pull/610]
I took the changes from the
[open-liberty|[https://github.com/OpenLiberty/open-liberty/]]-team (which are:
static final Pattern LINK_DELIMITER) and reworked them in a way that checkstyle
does not complain anymore. Their original commit had the static final variable
in lower-camel-case notation and below the instance variables, which is not
allowed. Also, the ArrayList was originally used for the variable, which is
also not allowed.
This is my first commit to an apache project. I hope I did this well enough. ;)
> Failure to parse multiple comma separated links in an HTTP Link header on a
> Jaxrs Response object
> -------------------------------------------------------------------------------------------------
>
> Key: CXF-8170
> URL: https://issues.apache.org/jira/browse/CXF-8170
> Project: CXF
> Issue Type: Bug
> Components: JAX-RS
> Affects Versions: 3.3.4
> Environment: Web
> Reporter: Ben M.
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {color:#FF0000}*Blocker: Specification violation resulting in
> RuntimeException*{color}
> Dear Apache Contributors,
> Recently I authored a pull request for OpenLiberty, which was then created by
> [https://github.com/WhiteCat22.]
>
> Original issue:
> [https://github.com/OpenLiberty/open-liberty/issues/8863]
>
> Original PR:
> [https://github.com/OpenLiberty/open-liberty/pull/8956]
> h2. Description
> If a server returns HTTP link headers, it may do so with responding multiple
> link headers, or just one link header with comma separated fields.
> CXF only recognizes multiple link headers. If only one link header with
> multiple values was supplied, it will throw an unexpected RuntimeException:
> {{java.lang.IllegalArgumentException: Illegal character in query at index
> n}}: (Link header here)
> {{Caused by: java.net.URISyntaxException: Illegal character in query at
> index}}
> h2. Examples
> h3. Working Response:
> {{HTTP/1.1}}
> {{Link: <http://localhost/api/endpoint?offset=0&sysparm_limit=5>;rel="first"}}
> {{Link: <http://localhost/api/endpoint?offset=5&sysparm_limit=5>;rel="next"}}
> {{Link: <http://localhost/api/endpoint?offset=45&sysparm_limit=5>;rel="last"}}
> h3. Not working response:
> {{HTTP/1.1}}
> {{Link:
> <http://localhost/api/endpoint?offset=0&sysparm_limit=5>;rel="first",<http://localhost/api/endpoint?offset=5&sysparm_limit=5>;rel="next",<http://localhost/api/endpoint?offset=45&sysparm_limit=5>;rel="last"}}
> That should have worked, though.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
