[
https://issues.apache.org/jira/browse/CXF-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andriy Redko resolved CXF-8712.
-------------------------------
Resolution: Fixed
> RetryStrategy tries one time too often
> --------------------------------------
>
> Key: CXF-8712
> URL: https://issues.apache.org/jira/browse/CXF-8712
> Project: CXF
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 3.4.7
> Reporter: Konrad Windszus
> Priority: Major
> Fix For: 4.0.0, 3.6.0, 3.5.4, 3.4.9
>
>
> The maxNumberOfRetries is not correctly evaluated in the RetryStrategy. If it
> is set to 3, the amount of retries is actually 4.
> This is due to the fact that {{getNextAlternate()}} will return the same
> result for both {{stillTheSameAddress}} returning either {{false}} or
> {{true}}.
> Although the break condition in
> https://github.com/apache/cxf/blob/75fb6bb56d82f72771a9ee6ecab5d36168303f51/rt/features/clustering/src/main/java/org/apache/cxf/clustering/RetryStrategy.java#L55
> is correct, the logic in
> https://github.com/apache/cxf/blob/75fb6bb56d82f72771a9ee6ecab5d36168303f51/rt/features/clustering/src/main/java/org/apache/cxf/clustering/RetryStrategy.java#L45
> is flawed, as it will not return the next alternate in case
> {{stillTheSameAddress}} returns false.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
