Thomas Cunningham created CXF-9107:
--------------------------------------
Summary: Clean up stream resource leaks
Key: CXF-9107
URL: https://issues.apache.org/jira/browse/CXF-9107
Project: CXF
Issue Type: Task
Reporter: Thomas Cunningham
Coverity is return a bunch of errors which can be easily cleaned up. The
first one in RMTxStore is a close of a ResultSet, the second in cxf-utils.js is
a typo in a method call (sring vs. string), and the third is a close of
realStream within JSONProvider.java.
Error: RESOURCE_LEAK (CWE-404):
rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/persistence/jdbc/RMTxStore.java:883:13:
alloc_fn: A new resource is returned from allocation method "getColumns".
rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/persistence/jdbc/RMTxStore.java:883:13:
var_assign: Assigning: "rs" = resource returned from
"metadata.getColumns(null, null, tableName, "%")".
rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/persistence/jdbc/RMTxStore.java:886:13:
noescape: Resource "rs" is not closed or saved in "next". (The virtual call
resolves to
"org.apache.activemq.artemis.jdbc.store.logging.LoggingResultSet.next".)
rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/persistence/jdbc/RMTxStore.java:887:17:
noescape: Resource "rs" is not closed or saved in "getString".
rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/persistence/jdbc/RMTxStore.java:886:13:
noescape: Resource "rs" is not closed or saved in "next". (The virtual call
resolves to
"org.apache.activemq.artemis.jdbc.store.logging.LoggingResultSet.next".)
rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/persistence/jdbc/RMTxStore.java:911:9:
leaked_resource: Variable "rs" going out of scope leaks the resource it refers
to.
# 909| }
# 910| }
# 911|-> } catch (SQLException ex) {
# 912| LOG.log(Level.WARNING, "Table " + tableName + " cannot be
altered.", ex);
# 913| }
Error: IDENTIFIER_TYPO (CWE-688):
rt/javascript/javascript-rt/src/main/resources/org/apache/cxf/javascript/cxf-utils.js:543:12:
identifier_typo: Using "org_apache_cxf_pad_sring" appears to be a typo:
* Identifier "org_apache_cxf_pad_sring" is only known to be referenced here, or
in copies of this code.
* Identifier "org_apache_cxf_pad_string" is referenced elsewhere at least 4
times.
rt/javascript/javascript-rt/src/main/resources/org/apache/cxf/javascript/cxf-utils.js:543:12:
remediation: Should identifier "org_apache_cxf_pad_sring" be replaced by
"org_apache_cxf_pad_string"?
rt/javascript/javascript-rt/src/main/resources/org/apache/cxf/javascript/cxf-utils.js:536:10:
identifier_use: Example 1: Using identifier "org_apache_cxf_pad_string" (2
total uses in this function).
rt/javascript/javascript-rt/src/main/resources/org/apache/cxf/javascript/cxf-utils.js:545:11:
identifier_use: Example 2: Using identifier "org_apache_cxf_pad_string".
rt/javascript/javascript-rt/src/main/resources/org/apache/cxf/javascript/cxf-utils.js:573:9:
identifier_use: Example 3: Using identifier "org_apache_cxf_pad_string".
# 541|
# 542| if (type == org_apache_cxf_pad_string_PAD_BOTH) {
# 543|-> string = org_apache_cxf_pad_sring(Math.floor(len / 2) +
string.length,
# 544| pad, org_apache_cxf_pad_string_PAD_LEFT);
# 545|
Error: RESOURCE_LEAK (CWE-404):
rt/rs/extensions/providers/src/main/java/org/apache/cxf/jaxrs/provider/json/JSONProvider.java:210:13:
alloc_fn: A new resource is returned from allocation method "getInputStream".
rt/rs/extensions/providers/src/main/java/org/apache/cxf/jaxrs/provider/json/JSONProvider.java:210:13:
var_assign: Assigning: "realStream" = resource returned from
"getInputStream(type, genericType, is)".
rt/rs/extensions/providers/src/main/java/org/apache/cxf/jaxrs/provider/json/JSONProvider.java:221:13:
leaked_resource: Variable "realStream" going out of scope leaks the resource
it refers to.
# 219| Class<?> theType = getActualType(theGenericType,
genericType, anns);
# 220|
# 221|-> unmarshaller = createUnmarshaller(theType, genericType,
isCollection);
# 222| XMLStreamReader xsr = createReader(type, realStream,
isCollection, enc);
# 223|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
