[ 
https://issues.apache.org/jira/browse/CXF-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136249#comment-18136249
 ] 

Valentino Porta commented on CXF-9267:
--------------------------------------

add PR https://github.com/apache/cxf/pull/3660

> Race Condition in HttpClientHTTPConduit.HttpClientBodyPublisher hides 
> Connection Timeout exception
> --------------------------------------------------------------------------------------------------
>
>                 Key: CXF-9267
>                 URL: https://issues.apache.org/jira/browse/CXF-9267
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 4.0.11, 4.1.9, 4.2.4
>            Reporter: Valentino Porta
>            Priority: Major
>         Attachments: close.png, histogram.png, noPublisher.png, 
> publisher_byte.png
>
>
> Hi everyone,
> I think we have a similar problem as the 
> https://issues.apache.org/jira/browse/CXF-9135 also in the 
> HttpClientHTTPConduit.HttpClientBodyPublisher . 
>  
> Let me explain. 
> I noticed that a race condition can happen where the [caller thread] close 
> the HttpClientBodyPublisher.close ...that set the stream=null ... and then 
> the [http client thread] try to subscribe to it... but finding stream==null 
> it gets a noBody() ... resulting in a "SocketTube(1) [HttpClient-1-Worker-0] 
> Too few bytes returned by the publisher (0/241)" Exception ... that covers 
> the real error (Connection Timed out). 
>  
> I noticed experimentally that this happens when :
>  * AllowChunking="true" in the Conduit
>  * payload are under chunkingThreshold (<4096) ... (I managed to replicate 
> only this scenario... I don't know for sure that also other are affected)
>  * Connection Timeout happens to be set as EXACTLY the value of the real 
> network delay
> I will attach a reproducer as soon as I close this ... with specific 
> instructions to replicate :) .
>  
> I also attach a screen of errors that I have that demonstrate that the max of 
> Too few bytes returned by the publisher (0/241) is approximately 4096... (It 
> could be also because it's the threshold so for sure there couldn't be 
> (0/8000) .... )  (publisher_byte.png).
> ...and some other screens to proof that the 2 threads are running into each 
> other!
>  
> Before I said 'EXACTLY' because (see histogram.png) I run some test pointing 
> to a free mock services online (thanks for the help 
> [https://app.beeceptor.com|https://app.beeceptor.com/)] ...) ...in order to 
> simulate some latency (my local wiremock was too fast and I had to set 
> timeout at 1/2 ms ).
> The real latency of the network was 180ms ... (see the reproducer under to 
> get command) .
> If I set connection timeout...I get that type of errors:
>  * 10<<180:
>  ** Could not send Message.
>  ** HTTP connect timed out
>  * 180 ≃ 180
>  ** Could not send Message.
>  ** HTTP connect timed out
>  ** request timed out (...I have no idea why and where this was thrown...but 
> yes)
>  ** SocketTube(1) [HttpClient-1-Worker-0] Too few bytes returned by the 
> publisher (0/241)
>  ** SSLTube(SocketTube(5)) stream=1 [HttpClient-1-Worker-0] Too few bytes 
> returned by the publisher (0/241)
>  * 1000 >> 180 : 
>  ** OK 200
> Our race conditions are:
>  * SocketTube if I was using "http".
>  * SSLTube(SocketTube(5)) if I was using "https".
> I will try open a PR... I already try some local build and setup some tests 
> ;) 
>  
>  



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to