[
https://issues.apache.org/jira/browse/DRILL-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aman Sinha updated DRILL-1488:
------------------------------
Attachment: 0002-DRILL-1488-Provide-configurable-option-to-set-the-sq.patch
Yes, that's a reasonable concern...I wanted to avoid creating a static variable
in DrillParserWithCompoundIdConverter.IDENTIFIER_MAX_LENGTH but did not have a
clean way to avoid it when I sent the patch for review. However, I realized
later that when creating the factory object SqlParserImplFactory I only need
the PlannerSettings.DEFAULT_IDENTIFIER_MAX_LENGTH since the DrillSqlWorker
will pass the updated option value when it creates the FrameworkConfig (as
part of parserConfig(new SqlParser.ParserConfigImpl(Lex.MYSQL, idMaxLength))).
I have made this change and an uploading a new patch which does not have that
static variable. Please take a look. Thanks.
> Limit on file name in sql query is too small
> --------------------------------------------
>
> Key: DRILL-1488
> URL: https://issues.apache.org/jira/browse/DRILL-1488
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Parth Chandra
> Assignee: Aman Sinha
> Priority: Blocker
> Fix For: 0.7.0
>
> Attachments:
> 0001-DRILL-1488-Provide-configurable-option-to-set-the-sq.patch,
> 0002-DRILL-1488-Provide-configurable-option-to-set-the-sq.patch
>
>
> While building from the release tarball, unit test fail if you build from a
> directory that is nested several levels deep such that the full path to some
> of the test data files is longer than 128 characters.
> The limit appears to be very small and should be increased.
> One of the errors during the build that illustrates the problem:
> testTextJoin(org.apache.drill.TestExampleQueries) Time elapsed: 0.011 sec
> <<< ERROR!
> org.apache.drill.exec.rpc.RpcException: Failure while parsing sql. Length of
> identifier
> 'file:/Users/pchandra/work/drill-release/apache-drill-0.6.0-incubating-src/exec/java-exec/target/test-classes/store/text/data/nations.csv'
> must be less than or equal to 128 characters
> [38933037-d38d-4278-a215-b722cc97811c]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
