[ 
https://issues.apache.org/jira/browse/DRILL-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Kishore updated DRILL-1879:
----------------------------------
    Attachment: DRILL-1879-Unit-test-failures-on-Windows.patch

If the string specified by the parameter {{replacement}} in the function  
{{java.lang.String.replaceAll(String regex, String replacement)}} contains 
either {{'\'}} or {{'$'}}, it is not treated like a literal and must be quoted 
using {{java.util.regex.Matcher.quoteReplacement(String)}}.

Windows paths have plenty of {{'\'}} in them. The attached patch fixes the 
issue. Unit tests on Windows and Linux have been passing since.

> Unit test failures on Windows
> -----------------------------
>
>                 Key: DRILL-1879
>                 URL: https://issues.apache.org/jira/browse/DRILL-1879
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>    Affects Versions: 0.7.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>             Fix For: 0.7.0
>
>         Attachments: DRILL-1879-Unit-test-failures-on-Windows.patch
>
>
> TestJsonReader#schemaChange failed with the following error:
> {noformat}
> org.apache.drill.exec.rpc.RpcException: Query failed: Failure validating SQL. 
> org.eigenbase.util.EigenbaseContextException:
> From line 1, column 15 to line 1, column 17:
> Table 
> 'dfs.X:gitapache-drillexecjava-exec/src/test/resources/vector/complex/writer/schemaChange/'
>  not found
>       at 
> org.apache.drill.exec.rpc.user.QueryResultHandler.batchArrived(QueryResultHandler.java:79)
>  ~[classes/:na]
>       at 
> org.apache.drill.exec.rpc.user.UserClient.handleReponse(UserClient.java:93) 
> ~[classes/:na]
>       at 
> org.apache.drill.exec.rpc.BasicClientWithConnection.handle(BasicClientWithConnection.java:52)
>  ~[classes/:na]
>       at 
> org.apache.drill.exec.rpc.BasicClientWithConnection.handle(BasicClientWithConnection.java:1)
>  ~[classes/:na]
>       at org.apache.drill.exec.rpc.RpcBus.handle(RpcBus.java:58) 
> ~[classes/:na]
>       at 
> org.apache.drill.exec.rpc.RpcBus$InboundHandler.decode(RpcBus.java:194) 
> ~[classes/:na]
>       at 
> org.apache.drill.exec.rpc.RpcBus$InboundHandler.decode(RpcBus.java:1) 
> ~[classes/:na]
>   {20 more}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to