[ 
https://issues.apache.org/jira/browse/DRILL-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379306#comment-14379306
 ] 

Daniel Barclay (Drill) edited comment on DRILL-2447 at 3/25/15 5:07 AM:
------------------------------------------------------------------------

When fixing this bug:

- Create a specific subclass of SQLException for the "object already closed" 
condition (perhaps AlreadyClosedSQLException).  Having a dedicated exception 
subclass will simplify test code (which probably will already be bulky because 
of the large number of methods involved).
- Make that new SQLException subclass a subclass of Drill's existing 
JdbcApiSqlException.
- Move JdbcApiSqlException from being a direct subclass of SQLException to 
being a subclass of SQLNonTransientException.


was (Author: dsbos):
When fixing this bug:

- Create a specific subclass of SQLException for the "object already closed" 
condition (perhaps AlreadyClosedSQLException).  Having a dedicated exception 
subclass will simplify test code (which probably will already be bulky because 
the large number of methods involved).
- Make that new SQLException subclass a subclass of Drill's existing 
JdbcApiSqlException.
- Move JdbcApiSqlException from being a direct subclass of SQLException to 
being a subclass of SQLNonTransientException.

> Calling getObject on a closed ResultSet object should throw a SQLException
> --------------------------------------------------------------------------
>
>                 Key: DRILL-2447
>                 URL: https://issues.apache.org/jira/browse/DRILL-2447
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - JDBC
>            Reporter: Rahul Challapalli
>            Assignee: Daniel Barclay (Drill)
>             Fix For: 1.1.0
>
>
> git.commit.id.abbrev=e92db23
> The following sequence should throw a SQLException according to the JDBC 
> specification. However drill's jdbc code does not throw an error
> {code}
> ResultSet rs = stmt.executeQuery("SELECT 1 FROM sys.version");
> rs.close();
> rs.getObject(1);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to