[ 
https://issues.apache.org/jira/browse/DRILL-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522741#comment-14522741
 ] 

Daniel Barclay (Drill) commented on DRILL-2933:
-----------------------------------------------

Additionally, there are a number of call in other methods declared to throw 
SchemaChangeException--so those methods don't signal schema change exceptions 
as expected.  

(To find those calls, declare that RecordBatchLoader.load(...) throws some 
unrelated checked exception (SQLException seems to work well) and follow the 
compilation errors.)



> RecordBatchLoader.load(...) calls catch SchemaChangeException that load(...) 
> never throws
> -----------------------------------------------------------------------------------------
>
>                 Key: DRILL-2933
>                 URL: https://issues.apache.org/jira/browse/DRILL-2933
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Daniel Barclay (Drill)
>
> There are about 9 calls to RecordBatchLoader.load(...) that apparently try to 
> detect schema changes by catching SchemaChangeException.
> However, RecordBatchLoader.load(...) never actually throws 
> SchemaChangeException to indicate a schema change--it returns true to 
> indicate that.
> Those 9 calls do not also check the return value, so they cannot detect 
> schema changes.
> (To find those calls, comment out the "throws SchemaChangeException" on 
> RecordBatchLoader.load(...) and follow the compilation errors.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to