[
https://issues.apache.org/jira/browse/DRILL-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528584#comment-14528584
]
Jacques Nadeau commented on DRILL-2774:
---------------------------------------
lgtm.
> Updated drill-patch-review.py to use git-format-patch
> -----------------------------------------------------
>
> Key: DRILL-2774
> URL: https://issues.apache.org/jira/browse/DRILL-2774
> Project: Apache Drill
> Issue Type: Bug
> Components: Tools, Build & Test
> Reporter: Steven Phillips
> Assignee: Steven Phillips
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: DRILL-2774.patch, DRILL-2774.patch
>
>
> The tool currently uses git diff to generate the patches, which does not
> preserve commit information, and which is required for submitting patches in
> the Drill community.
> This doesn't work properly when there are multiple commits, so as part of
> this change, we enforce the requirement that the branch used to create the
> patch is exactly one commit ahead and zero behind the remote branch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)