[
https://issues.apache.org/jira/browse/DRILL-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531374#comment-14531374
]
Daniel Barclay (Drill) commented on DRILL-2961:
-----------------------------------------------
Part 1:
DRILL-2961: Part 2--Core: Have set...Timeout methods throw rather than ignore.
Changed implementation of Statement.setQueryTimeout(...) and
Connection.setNetworkTimeout(...) to throw SQLFeatureNotSupportedException
rather than silently not setting timeout.
Main:
- Added implementations of Statement.{set,get}QueryTimeout(...) and
Connection.{set,get}NetworkTimeout(...) methods (in classes DrillStatementImpl,
DrillConnectionImpl).
- Added Drill-specific narrowed declarations and documentation (in interfaces
DrillStatement and DrillConnection).
- Added unit tests (in new StatementTest, ConnectionTest).
Narrowed other thrown exceptions to allow narrowing in above methods:
- Narrowed exceptions on isClosed() and checkNotClosed() (in
DrillConnectionImpl, DrillStatementImpl).
- Added InvalidParameterSqlException.
> Statement.setQueryTimeout() should throw a SQLException
> -------------------------------------------------------
>
> Key: DRILL-2961
> URL: https://issues.apache.org/jira/browse/DRILL-2961
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Affects Versions: 1.0.0
> Environment: RHEL 6.4
> Reporter: Kunal Khatua
> Assignee: Daniel Barclay (Drill)
> Fix For: 1.0.0
>
> Attachments: DRILL-2961.1Prep.1.patch.txt,
> DRILL-2961.2Core.1.patch.txt
>
>
> When trying to set the timeout for a Drill Statement object, Drill does not
> report any SQLException which makes the developer incorrectly believe that a
> timeout has been set.
> The operation should throw the exception:
> java.sql.SQLException: Method not supported
> at
> org.apache.drill.jdbc.DrillStatement.setQueryTimeout(DrillStatement.java)
> ....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
