[
https://issues.apache.org/jira/browse/DRILL-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531374#comment-14531374
]
Daniel Barclay (Drill) edited comment on DRILL-2961 at 5/6/15 11:58 PM:
------------------------------------------------------------------------
Part 1:
DRILL-2961: Part 1--Prep., Hyg.: Split DrillStatement -> DrillStatement{,Impl}.
Preparation for query/network timeout methods:
- Moved class ...jdbc.DrillStatement to ...jdbc.impl.DrillStatementImpl.
- Created interface ...jdbc.DrillStatement interface, extending
java.sql.Statement (for place for Drill-specific narrowed declarations and
documentation). Declared DrillStatementImpl to implement new DrillStatement.
- Updated references.
- Adjusted visibility (temporarily make somethings publich until DRILL-2089 is
done more).
Misc. code hygiene:
- Purged extraneous imports of ResultSet.
- Purged TODO made obsolete by UserException.
- Misc. whitespace.
was (Author: dsbos):
Part 1:
DRILL-2961: Part 1--Prep., Hyg.: Split DrillStatement -> DrillStatement{,Impl}.
Preparation for query/network timeout methods:
- Moved class ...jdbc.DrillStatement to ...jdbc.impl.DrillStatementImpl.
- Created interface ...jdbc.DrillStatement interface, extending
java.sql.Statement (for place for Drill-specific narrowed declarations and
documentation). Declared DrillStatementImpl to implement new DrillStatement.
- Updated references.
- Adjusted visibility (temporarily make somethings publich until DRILL-2089 is
done more).
Misc. code hygiene:
- Purged extraneous imports of ResultSet.
- Purged TODO made obsolete by UserException.
- Misc. whitespace.
> Statement.setQueryTimeout() should throw a SQLException
> -------------------------------------------------------
>
> Key: DRILL-2961
> URL: https://issues.apache.org/jira/browse/DRILL-2961
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Affects Versions: 1.0.0
> Environment: RHEL 6.4
> Reporter: Kunal Khatua
> Assignee: Daniel Barclay (Drill)
> Fix For: 1.0.0
>
> Attachments: DRILL-2961.1Prep.2.patch.txt,
> DRILL-2961.1Prep.3.patch.txt, DRILL-2961.2Core.2.patch.txt,
> DRILL-2961.2Core.3.patch.txt
>
>
> When trying to set the timeout for a Drill Statement object, Drill does not
> report any SQLException which makes the developer incorrectly believe that a
> timeout has been set.
> The operation should throw the exception:
> java.sql.SQLException: Method not supported
> at
> org.apache.drill.jdbc.DrillStatement.setQueryTimeout(DrillStatement.java)
> ....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
