[ 
https://issues.apache.org/jira/browse/DRILL-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540512#comment-14540512
 ] 

Daniel Barclay (Drill) commented on DRILL-2933:
-----------------------------------------------

Note:  If it is intended that RecordBatchLoader.load(...) declares that it 
throws SchemaChangeException in order to "reserve the right" to throw that 
exception in the future (e.g., to help make sure that current callers are 
already prepared for that case), then there's no problem (except that 
SchemaChangeException and load's throwing of SchemaChangeException could use at 
least minimal documentation).


> RecordBatchLoader.load(...) calls catch SchemaChangeException that load(...) 
> never actually throws
> --------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-2933
>                 URL: https://issues.apache.org/jira/browse/DRILL-2933
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Daniel Barclay (Drill)
>             Fix For: 1.2.0
>
>
> There are about 9 calls to RecordBatchLoader.load(...) that catch 
> SchemaChangeException because it is declared to be thrown by 
> RecordBatchLoader.load(...).
> However, RecordBatchLoader.load(...) never actually throws 
> SchemaChangeException.
> (To find those calls, comment out the "throws SchemaChangeException" on 
> RecordBatchLoader.load(...) and follow the compilation errors.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to