[
https://issues.apache.org/jira/browse/DRILL-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540684#comment-14540684
]
Deneche A. Hakim edited comment on DRILL-2229 at 5/12/15 8:48 PM:
------------------------------------------------------------------
I just took a look at the patch. You may want to update the following:
{code}
throw UserException.parseError()
.message(e.getMessage())
.build();
{code}
to just:
{code}
throw UserException.parseError(e).build();
{code}
The builder will use the wrapped exception message .message() is not called.
Thanks!
was (Author: adeneche):
I just took a look at the patch. You may want to update the following:
{code}
throw UserException.parseError()
.message(e.getMessage())
.build();
{code}
to just:
{code}
throw UserException.parseError(e).build();
The builder will use the wrapped exception message .message() is not called.
{code}
Thanks!
> SQL syntax errors should use SQLSyntaxErrorException
> ----------------------------------------------------
>
> Key: DRILL-2229
> URL: https://issues.apache.org/jira/browse/DRILL-2229
> Project: Apache Drill
> Issue Type: Bug
> Components: SQL Parser
> Reporter: Daniel Barclay (Drill)
> Assignee: Aman Sinha
> Fix For: 1.2.0
>
> Attachments: DRILL-2229.1.patch, DRILL-2229.2.patch
>
>
> SQL syntax errors should be reported with SQLSyntaxErrorException (or
> subclasses, of course) rather than SQLException (in part so that when they
> get to the JDBC interface they can be reported at intended using
> SQLSyntaxErrorException .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
