[ 
https://issues.apache.org/jira/browse/DRILL-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549233#comment-14549233
 ] 

Daniel Barclay (Drill) commented on DRILL-3132:
-----------------------------------------------

> override UserException.printStackTrace() to print the stack trace of the 
> original exception, or in the case of UserRemoteException the stack trace 
> that was passed with the pberror object.

No, please!  Overriding the standard behavior of Throwable's toString and 
printStackTrace methods in a subclass (e.g., UserException) can make it really 
hard to debug things. 

Why do you think you want to override printStackTrace?  

> Improve User Exceptions
> -----------------------
>
>                 Key: DRILL-3132
>                 URL: https://issues.apache.org/jira/browse/DRILL-3132
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Deneche A. Hakim
>            Assignee: Deneche A. Hakim
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> - add getErrorType(). UserRemoteException should return the error type of the 
> underlying pberror object
> - override UserException.printStackTrace() to print the stack trace of the 
> original exception, or in the case of UserRemoteException the stack trace 
> that was passed with the pberror object.
> - user exception context can store "debug" informations that will only be 
> visible for system errors or in verbose mode



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to